1326593 - Disabled sound indicator blinks in tab when audio stops

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[arni2033]

>>>   My Info:   Win7_64, Nightly 53, 32bit, ID 20161119030204 (2016-11-19)
STR_1:
1. Open https://www.iandevlin.com/html5test/webvtt/html5-video-webvtt-sample.html
2. Mute the tab (Ctrl+M)
3. Doubleclick play button in video controls
4. Wait 3 seconds

AR:  Sound indicator blinks in tab when audio stops (briefly disappears, then appears again)
ER:  Sound indicator shouldn't blink

This is regression from bug 1311799. Regression range:
> https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=b99f3a05db461e9a4384d95a95c7ecbfde863bc4&tochange=36105103e8699a45893b16745e8b8f85daebf82a

Comment 1

[arni2033]

@ Jared Wein [:jaws] (please needinfo? me):
It seems that this is a regresion caused by your change. Please have a look.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1326593 - Keep the soundplaying icon visible after audio has stopped playing if the tab has been muted.

Review commit: https://reviewboard.mozilla.org/r/101946/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/101946/

Comment 3

[Dave Townsend [:mossop]]

Comment on attachment 8823433 [details]
Bug 1326593 - Keep the soundplaying icon visible after audio has stopped playing if the tab has been muted.

https://reviewboard.mozilla.org/r/101946/#review102346

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1aa5bd4c4769
Keep the soundplaying icon visible after audio has stopped playing if the tab has been muted. r=mossop

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1aa5bd4c4769

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Please request Aurora approval on this when you get a chance.

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8823433 [details]
Bug 1326593 - Keep the soundplaying icon visible after audio has stopped playing if the tab has been muted.

Approval Request Comment
[Feature/Bug causing the regression]: regression from bug 1311799
[User impact if declined]: sound icon may fade out unnecessarily
[Is this code covered by automated tests?]: no, manual testing
[Has the fix been verified in Nightly?]: yes, by myself
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no, simple css change
[Why is the change risky/not risky?]: simple css change
[String changes made/needed]: none

Comment 8

[Julien Cristau [:jcristau] (back April 22)]

Comment on attachment 8823433 [details]
Bug 1326593 - Keep the soundplaying icon visible after audio has stopped playing if the tab has been muted.

fix ui regression in aurora52

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/39fd680b2e51

Comment 10

[Azmina]

I have reproduced this bug on Nightly 53.0a1 (2016-12-31) (32-bit) , Windows 8.1 (64-bit).

This bug's fix is verified on Latest Nightly 53.0a1 and Aurora 52.0a2.

Latest Nightly
Build ID : 20170111030235
User Agent : Mozilla/5.0 (Windows NT 6.3; WOW64; rv:53.0) Gecko/20100101 Firefox/53.0

Aurora
Build ID : 20170112004017
User Agent :Mozilla/5.0 (Windows NT 6.3; WOW64; rv:52.0) Gecko/20100101 Firefox/52.0

[bugday-20170111]