Closed Bug 1326659 Opened 6 years ago Closed 2 years ago

Notifications in devtools are not accessible with keyboard (a11y)

Categories

(DevTools :: Shared Components, defect, P3)

Product:
DevTools
Component:
Shared Components
Type:
defect

Tracking

(firefox-esr78 wontfix, firefox83 wontfix, firefox84 wontfix, firefox85 fixed)

Status:
RESOLVED FIXED
Milestone:
85 Branch
Tracking Flags:
Tracking Status
firefox-esr78 --- wontfix
firefox83 --- wontfix
firefox84 --- wontfix
firefox85 --- fixed

People

(Reporter: arni2033, Assigned: jdescottes)

References

(Regression)

Details

(Keywords: access, regression)

Attachments

(2 files)

Bug 1326659 - [devtools] Use button element to render close button in NotificationBox
47 bytes, text/x-phabricator-request
Details | Review
Bug 1326659 - [devtools] Remove macos skipif for browser_toolbox_keyboard_navigation.js
47 bytes, text/x-phabricator-request
Details | Review 
>>>   My Info:   Win7_64, Nightly 49, 32bit, ID 20160526082509
STR_1:
1. Open url [1], wait until it's fully loaded (blue spinner in tab should disappear)
2. Open style editor (Shift+F7), wait until red notification appears in devtools
3. Click on the page
4. Press Tab key

AR:  "Pick an element from the page" button is focused in devtools
ER:  Close button inside notification should be accessible, just like in normal <notification>s

> [1] data:text/html,<link rel="stylesheet" type="text/css" href="http://asdf.asdf/pain.css">

This is regression from bug 1264671. Regression ragne:
> https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=be6dbfceb79e570e6859200c2c5a8673f58c277e&tochange=bec48bfd05a8c6703aab63181441869a3dcaa4cc
No longer blocks: 1277113
Component: Untriaged → Developer Tools: Framework
Component: Developer Tools: Framework → Developer Tools: Shared Components
Product: Firefox → DevTools
Severity: normal → S3
Priority: -- → P3

Depends on D98987
Try push looks ok without the skip-if, might be fine to remove it

Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8dae0f4af8f8
[devtools] Use button element to render close button in NotificationBox r=nchevobbe,yzen
https://hg.mozilla.org/integration/autoland/rev/c9a470a98696
[devtools] Remove macos skipif for browser_toolbox_keyboard_navigation.js r=yzen

https://hg.mozilla.org/mozilla-central/rev/8dae0f4af8f8
https://hg.mozilla.org/mozilla-central/rev/c9a470a98696

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox85: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 85 Branch
No longer blocks: 1264671
status-firefox83: --- → wontfix
status-firefox84: --- → wontfix
status-firefox-esr78: --- → wontfix
Regressed by: 1264671
Regressions: 1701562
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.