Open Bug 1326984 Opened 7 years ago Updated 2 years ago

Ruleview is confused by 2 rules for the same property

Categories

(DevTools :: Inspector: Rules, defect, P2)

Product:
DevTools
Component:
Inspector: Rules
Type:
defect

Tracking

(Not tracked)

Status:
REOPENED

People

(Reporter: arni2033, Unassigned)

Details

Attachments

(1 file)

bug1326984_strs.gif
497.24 KB, image/gif
Details 
>>>   My Info:   Win7_64, Nightly 49, 32bit, ID 20160526082509
STR_1:
1. Open url   data:text/html,<body style="color:red !important;color:white"><b>R
2. Open inspector -> ruleview
3. Click on checkbox near rule "color: white;" to disable that rule
4. Click on checkbox near rule "color: white;" to enable that rule

AR:
 Step 3 - both rules become disabled and not applied
 Step 4 - rule "color: white;" becomes enabled and applied

ER:
 Step 3 - rule "color: white;" should become disabled. That's all expected changes
 Step 4 - rule "color: white;" should become enabled. That's all expected changes



STR_2:
1. Open url   data:text/html,<body style="color:red !important;color:white"><b>R
2. Open inspector -> ruleview
3. Click on checkbox near rule "color: red !important;" to disable that rule
4. Click on checkbox near rule "color: red !important;" to enable that rule
5. Click on checkbox near rule "color: red !important;" TWICE to toggle the rule twice

AR:
 Step 4 - rule "color: red !important;" is applied, but looks disabled and not applied in ruleview
 Step 5 - rule "color: red !important;" STAYS applied, but looks disabled and not applied in ruleview

ER:
 Step 4 - rule "color: red !important;" should be displayed as enabled and applied in ruleview
 Step 5 - Each time I toggle checkbox:   Rule "color: red !important;" should change 3 things:
         "is it really applied", "is it 'enabled' in ruleview" and "is it 'applied' in ruleview"
          Rule "color: white;" should change "is it really applied" and "is it 'applied' in ruleview"
No longer blocks: 1277113
Component: Untriaged → Developer Tools: CSS Rules Inspector
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
>>>   My Info:   Win7_64, Nightly 53, 32bit, ID 20170104030214 (2017-01-04)
Reproducible, even though marked as duplicate of fixed bug.
Flags: needinfo?(ttromey)
(In reply to castiel743 from comment #2)
> >>>   My Info:   Win7_64, Nightly 53, 32bit, ID 20170104030214 (2017-01-04)
> Reproducible, even though marked as duplicate of fixed bug.

I can't reproduce it.  I don't mind reopening it while we discuss though.

When I do this, I see the body's style change in the markup view.
For example when I disable the "red" I see:

<body style="/*! color:red !important; */color:white;">

The commenting is what makes this work.

This is actually a bit surprising to me since I would have expected element styles
not to be edited as-authored.  I didn't investigate this however.
Status: RESOLVED → REOPENED
Flags: needinfo?(ttromey)
Resolution: DUPLICATE → ---
I can reproduce, I'll attach a gif to illustrate. 

Basically when you uncheck the second color rule, the first one gets unchecked and striked.
Priority: -- → P2
Can you try bug 913661 as well?
Maybe that one should be reopened.

I wonder why I can't reproduce.
I do see in the gif that the commenting is working properly in the element style.
Flags: needinfo?(jdescottes)
Just tried the STRs from Bug 913661 as well as Bug 913661 comment 2, and both are fixed for me. 

As a reference I am on https://hg.mozilla.org/mozilla-central/rev/e68cbc3b5b3d and testing on OSX.
I'll try on Linux later today, maybe this is platform specific?
Flags: needinfo?(jdescottes)
Product: Firefox → DevTools
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: