1327118 - [e10s] Text encoding menuitems are all disabled when tab is moved to another window

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[arni2033]

>>>   My Info:   Win7_64, Nightly 49, 32bit, ID 20160526082509
STR_1:
0. Enable menu bar, move "Text encoding" toolbarbutton
1. Open http://example.org/ in a new tab
2. Right-click on the tab, click "Move to new window"
3. Click Menu bar -> View. Click "Text encoding" toolbarbutton

AR:  Menuitem "Text encoding" in Menu bar -> View AND all items in "Text encoding" panel are disabled
ER:  Menuitem "Text encoding" should be enabled. All items in "Text encoding" panel should be enabled

Comment 1

[Cosmin Muntean [:cmuntean], Ecosystem QA (PTO until March 24)]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:50.0) Gecko/20100101 Firefox/50.0
Firefox: 50.1.0, Build ID: 20161208153507

I have managed to reproduce this issue on latest Firefox (50.1.0) release and latest Nightly (53.0a1) build. 
I have observed that after the new window is opened and you refresh the page, the issue is no longer reproducible.

Comment 2

[:Gijs (he/him)]

:mrbkap, in e10s when I follow the steps in comment #0, I get a spinner on the tab in the new window as well. I imagine that's related. Any chance you know of a bug tracking that and/or if that's going to fix this bug?

(I tried just copying over the characterSet property and so on when moving the tab between windows, and that doesn't seem to have fixed it, but it's possible I missed something.)

Comment 3

[Julien Cristau [:jcristau]]

Too late for firefox 52, mass-wontfix.

Comment 4

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Bug 1327118 - Fix the charset encoding menu not being properly enabled when dragging tabs into a new window.

Review commit: https://reviewboard.mozilla.org/r/146444/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/146444/

Comment 5

[Blake Kaplan (:mrbkap) (inactive)]

(In reply to :Gijs from comment #2)
> :mrbkap, in e10s when I follow the steps in comment #0, I get a spinner on
> the tab in the new window as well. I imagine that's related. Any chance you
> know of a bug tracking that and/or if that's going to fix this bug?

This fell off my radar. I believe that this problem was fixed in bug 1350324. It left the character set menu bug, which was easy to fix and test.

Comment 6

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 8875078 [details]
Bug 1327118 - Fix the charset encoding menu not being properly enabled when dragging tabs into a new window.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/146444/diff/1-2/

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8875078 [details]
Bug 1327118 - Fix the charset encoding menu not being properly enabled when dragging tabs into a new window.

https://reviewboard.mozilla.org/r/146444/#review152044

Great! Thanks for the test!

Comment 8

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8875078 [details]
Bug 1327118 - Fix the charset encoding menu not being properly enabled when dragging tabs into a new window.

https://reviewboard.mozilla.org/r/146444/#review152046

Whoops, forgot to set the flag.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ae620d7e41e2
Fix the charset encoding menu not being properly enabled when dragging tabs into a new window. r=mconley

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/ae620d7e41e2

Comment 11

[Sylvestre Ledru [:Sylvestre]]

I guess we want this to ride the trains.

Comment 12

[Anika Alam Raha]

I have reproduced this bug with Nightly 53.0a1 (2017-01-01) on Windows 8, 64-bit.

The bug's fix is now verified on Latest Beta 55.0b9

Build ID 	20170713130618
User Agent 	Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0

[bugday-20170712]