Closed
Bug 1327118
Opened 7 years ago
Closed 7 years ago
[e10s] Text encoding menuitems are all disabled when tab is moved to another window
Categories
(Firefox :: Toolbars and Customization, defect)
Firefox
Toolbars and Customization
Tracking
()
VERIFIED
FIXED
Firefox 55
People
(Reporter: arni2033, Assigned: mrbkap)
Details
Attachments
(1 file)
>>> My Info: Win7_64, Nightly 49, 32bit, ID 20160526082509 STR_1: 0. Enable menu bar, move "Text encoding" toolbarbutton 1. Open http://example.org/ in a new tab 2. Right-click on the tab, click "Move to new window" 3. Click Menu bar -> View. Click "Text encoding" toolbarbutton AR: Menuitem "Text encoding" in Menu bar -> View AND all items in "Text encoding" panel are disabled ER: Menuitem "Text encoding" should be enabled. All items in "Text encoding" panel should be enabled
Comment 1•7 years ago
|
||
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:50.0) Gecko/20100101 Firefox/50.0 Firefox: 50.1.0, Build ID: 20161208153507 I have managed to reproduce this issue on latest Firefox (50.1.0) release and latest Nightly (53.0a1) build. I have observed that after the new window is opened and you refresh the page, the issue is no longer reproducible.
status-firefox50:
--- → affected
status-firefox51:
--- → affected
status-firefox52:
--- → affected
status-firefox53:
--- → affected
Component: Untriaged → Toolbars and Customization
Updated•7 years ago
|
Flags: needinfo?(gijskruitbosch+bugs)
Comment 2•7 years ago
|
||
:mrbkap, in e10s when I follow the steps in comment #0, I get a spinner on the tab in the new window as well. I imagine that's related. Any chance you know of a bug tracking that and/or if that's going to fix this bug? (I tried just copying over the characterSet property and so on when moving the tab between windows, and that doesn't seem to have fixed it, but it's possible I missed something.)
Flags: needinfo?(gijskruitbosch+bugs) → needinfo?(mrbkap)
Comment 3•7 years ago
|
||
Too late for firefox 52, mass-wontfix.
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → mrbkap
Flags: needinfo?(mrbkap)
Assignee | ||
Comment 5•7 years ago
|
||
(In reply to :Gijs from comment #2) > :mrbkap, in e10s when I follow the steps in comment #0, I get a spinner on > the tab in the new window as well. I imagine that's related. Any chance you > know of a bug tracking that and/or if that's going to fix this bug? This fell off my radar. I believe that this problem was fixed in bug 1350324. It left the character set menu bug, which was easy to fix and test.
Comment hidden (mozreview-request) |
Comment 7•7 years ago
|
||
mozreview-review |
Comment on attachment 8875078 [details] Bug 1327118 - Fix the charset encoding menu not being properly enabled when dragging tabs into a new window. https://reviewboard.mozilla.org/r/146444/#review152044 Great! Thanks for the test!
Comment 8•7 years ago
|
||
mozreview-review |
Comment on attachment 8875078 [details] Bug 1327118 - Fix the charset encoding menu not being properly enabled when dragging tabs into a new window. https://reviewboard.mozilla.org/r/146444/#review152046 Whoops, forgot to set the flag.
Attachment #8875078 -
Flags: review?(mconley) → review+
Pushed by mrbkap@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ae620d7e41e2 Fix the charset encoding menu not being properly enabled when dragging tabs into a new window. r=mconley
![]() |
||
Comment 10•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/ae620d7e41e2
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Comment 11•7 years ago
|
||
I guess we want this to ride the trains.
Comment 12•7 years ago
|
||
I have reproduced this bug with Nightly 53.0a1 (2017-01-01) on Windows 8, 64-bit. The bug's fix is now verified on Latest Beta 55.0b9 Build ID 20170713130618 User Agent Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0 [bugday-20170712]
Updated•7 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•