The default bug view has changed. See this FAQ.

Can't open "Blocked popup" menu with a single click on "Blocked popup" button in urlbar if another popup is open

RESOLVED FIXED in Firefox 53

Status

()

Firefox
Location Bar
RESOLVED FIXED
3 months ago
14 days ago

People

(Reporter: arni2033, Assigned: mak)

Tracking

({regression})

Trunk
Firefox 54
regression
Points:
---
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox50 wontfix, firefox51 wontfix, firefox52 wontfix, firefox53 fixed, firefox54 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

3 months ago
str
>>>   My Info:   Win7_64, Nightly 52, 32bit, ID 20161028030204 (2016-10-28)
STR_1:
1. Open url https://www.mozilla.org/en-US/firefox/nightly/firstrun/
2. Open console, execute   "window.open("t1o2xfgmes.html","","height=400")"   w/o outer quotes
3. Click "Options" button in the yellow bar appeared in Step 2
4. Click "Blocked popup" button in urlbar

AR:  Popup opened in Step 3 closes, and no other actions happen
ER:  Step 4 - "Blocked popup" menu should open

Note:  Dropmarkers in urlbar and searchbar work normally, so it's only "blocked popup" button broken

This is regression from bug 1251569. Regression range:
> https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=7deb2a00563d8f87b64dcaefcaaf223937aee1ef&tochange=19b283720e079584b5fbfcbc55fd8776e35ca598
(Reporter)

Updated

3 months ago
No longer blocks: 1277113
(Reporter)

Updated

3 months ago
Component: Untriaged → WebExtensions: Untriaged
Product: Firefox → Toolkit

Updated

3 months ago
Component: WebExtensions: Untriaged → Untriaged
Product: Toolkit → Firefox
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:50.0) Gecko/20100101 Firefox/50.0
Firefox: 50.1.0, Build ID: 20161208153507

I have managed to reproduce this issue on latest Firefox (50.1.0) release and latest Nightly (53.0a1) build.

Marco, can you please take a look over this?
status-firefox50: --- → affected
status-firefox51: --- → affected
status-firefox52: --- → affected
status-firefox53: --- → affected
Component: Untriaged → XUL Widgets
Flags: needinfo?(mak77)
Product: Firefox → Toolkit
(Assignee)

Comment 2

2 months ago
to me looks like the first click hides the options popup, the second click opens the blocked popups one.
So, basically the regression is that it required 2 clicks instead of one.

I suspect the onPopupHiding handler is handling too many events.
I will have a look at it, not a priority, since it's just one added click, afaict.
Assignee: nobody → mak77
Status: NEW → ASSIGNED
Component: XUL Widgets → Location Bar
Flags: needinfo?(mak77)
Product: Toolkit → Firefox
(Assignee)

Updated

2 months ago
status-firefox50: affected → wontfix
status-firefox51: affected → wontfix
status-firefox52: affected → fix-optional
Comment hidden (mozreview-request)
(Assignee)

Comment 4

2 months ago
I expanded the comment to better explain what's up.
The idea is to go back to handling the open on click, as it was before, but we still need mousedown to know if we are in the same tick as popuphiding. There are various possibilities to implement this, like registering both handlers, or trying fancy stuff to cancel the click from mousedown. But off-hand I think this is the most readable.

Comment 5

2 months ago
mozreview-review
Comment on attachment 8831071 [details]
Bug 1327155 - Can't open urlbar Blocked Popups menu with a single click if it's already open from the notification bar.

https://reviewboard.mozilla.org/r/107728/#review109322
Attachment #8831071 - Flags: review?(felipc) → review+

Comment 6

2 months ago
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/b1b0f99b73fc
Can't open urlbar Blocked Popups menu with a single click if it's already open from the notification bar. r=Felipe

Comment 7

2 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/b1b0f99b73fc
Status: ASSIGNED → RESOLVED
Last Resolved: 2 months ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54

Comment 8

2 months ago
I have reproduced this bug with Nightly 53.0a1 (2017-01-01) (64-bit)

The Bug's fix is now verified on latest Nightly 54.0a1

Build ID 	20170202030211
User Agent 	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:54.0) Gecko/20100101 Firefox/54.0

[bugday-20170201]
Please request Aurora/Beta approval on this when you're ready to do so.
Flags: needinfo?(mak77)
(Assignee)

Comment 10

2 months ago
Comment on attachment 8831071 [details]
Bug 1327155 - Can't open urlbar Blocked Popups menu with a single click if it's already open from the notification bar.

Approval Request Comment
[Feature/Bug causing the regression]: bug 1251569 
[User impact if declined]: minor annoyance when clicking on the blocked popups panel, it may not open at the first click
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no
[Why is the change risky/not risky?]: trivial code change
[String changes made/needed]: none
Flags: needinfo?(mak77)
Attachment #8831071 - Flags: approval-mozilla-beta?
Attachment #8831071 - Flags: approval-mozilla-aurora?
Comment on attachment 8831071 [details]
Bug 1327155 - Can't open urlbar Blocked Popups menu with a single click if it's already open from the notification bar.

Polish a UI behavior when clicking on the blocked popups panel. Aurora53+.
Attachment #8831071 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

Comment 12

2 months ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/8c15bbe4488d
status-firefox53: affected → fixed

Comment 13

2 months ago
I have reproduced this bug with Nightly 53.0a1 (2017-01-01) (64-bit) on Linux 64-bit (Manjaro 16) 

While verifying the fix with latest Nightly 54.0a1 in 64 bit Linux (Manjaro 16), I found that it is still reproducible.

build id:   20170203110047
user agent: Mozilla/5.0 (X11; Linux x86_64; rv:54.0) Gecko/20100101 Firefox/54.0

[testday-20170203]
Comment on attachment 8831071 [details]
Bug 1327155 - Can't open urlbar Blocked Popups menu with a single click if it's already open from the notification bar.

Seems a bit of a corner case, I'm not too keen on taking this in beta.
Attachment #8831071 - Flags: approval-mozilla-beta? → approval-mozilla-beta-
status-firefox52: fix-optional → wontfix
Setting qe-verify- based on Marco's assessment on manual testing needs (see Comment 10), but flagging it as a candidate for the community.
QA Whiteboard: [good first verify]
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.