132733 - bidi support for animated alerts

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Scott MacGregor]

A spin off bug from #132643. Currently the animated alert comes up over the
lower right hand portion of the window, above the system tray. We need to look
into adding the ability to have it come up over the bottom left hand side for
certain languages were that is more appropriate.

Comment 1

[scottputterman]

I'd like to minus this, but I wanted to get i18n's input on how crucial this is.

Comment 2

[Simon Montagu :smontagu]

It may Just Work in Windows with RTL UI. Shoshannah, do you have a machine where
you can test it?

Comment 3

[Michael Buckland]

Discussed in Mail News bug meeting, decided to minus this bug.

Comment 4

[Jens Bannmann]

(In reply to comment #2)
> It may Just Work in Windows with RTL UI.

Unless Windows with RTL UI interprets a window's x coordinates the other way
round (x=0 being the right screen edge), it won't work. The coordinates are
calculated in platform-neutral JS code, and hard-coded to be the lower right
corner (i.e. x and y near screen width and height).

Comment 5

[Simon Montagu :smontagu]

(In reply to comment #4)
> (In reply to comment #2)
> > It may Just Work in Windows with RTL UI.
> 
> Unless Windows with RTL UI interprets a window's x coordinates the other way
> round (x=0 being the right screen edge), it won't work.

That's what it does. See
http://www.microsoft.com/globaldev/getwr/steps/WRG_mirror.mspx

Comment 6

[Simon Montagu :smontagu]

Attachment: patch

I was too optimistic about this Just Working in RTL windows. It doesn't work and it's getting on my nerves. This patch will fix it for thunderbird and other toolkit apps. For Seamonkey mail, bug 345238 is also required.

Comment 7

[Ere Maijala (slow)]

Comment on attachment 247669 [details] [diff] [review]
patch

Could you prepend GetWindowLong with ::? I know it's already inconsistent, but anyway...
I couldn't actually try this, but the code looks good.
r=emaijala

Comment 8

[Simon Montagu :smontagu]

Comment on attachment 247669 [details] [diff] [review]
patch

In reply to comment #7)
> Could you prepend GetWindowLong with ::?
I'll do this before checking in.

Comment 9

[[e-mail]]

Comment on attachment 247669 [details] [diff] [review]
patch

>+                  // If the task bar is right-to-left, move the origin to the
>+                  // left
>+                  if (GetWindowLong(shellWindow, GWL_EXSTYLE) & WS_EX_LAYOUTRTL)
The :: is going to push the line length over 80 chars, so you might as well join the "left" on to the previous line while you're at it ;-)

Comment 10

[Simon Montagu :smontagu]

Checked in.

Comment 11

[Bill Gianopoulos [:WG9s]]

This appears to have broken the windows thunderbird build.

http://tinderbox.mozilla.org/Thunderbird/

Comment 12

[Simon Montagu :smontagu]

I have no idea why that should happen, since as far as I know WS_EX_LAYOUTRTL has been defined since VC 6 at least, but I checked in an "#ifndef ... #define ..." which fixed the bustage.

Comment 13

[Scott MacGregor]

I heard the Thunderbird trunk build has a winver set on it that it shouldn't:

See Bug 362478. We need to get that removed.