bidi support for animated alerts

RESOLVED FIXED in mozilla1.2alpha

Status

SeaMonkey
UI Design
RESOLVED FIXED
16 years ago
11 years ago

People

(Reporter: Scott MacGregor, Assigned: smontagu)

Tracking

Trunk
mozilla1.2alpha
x86
Windows 2000

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

2.10 KB, patch
Ere Maijala (slow)
: review+
neil@parkwaycc.co.uk
: superreview+
Details | Diff | Splinter Review
(Reporter)

Description

16 years ago
A spin off bug from #132643. Currently the animated alert comes up over the
lower right hand portion of the window, above the system tray. We need to look
into adding the ability to have it come up over the bottom left hand side for
certain languages were that is more appropriate.
(Reporter)

Updated

16 years ago
Status: NEW → ASSIGNED
Keywords: nsbeta1
QA Contact: paw → stephend
QA Contact: stephend → gchan

Comment 1

16 years ago
I'd like to minus this, but I wanted to get i18n's input on how crucial this is.
Whiteboard: [need info]
(Assignee)

Comment 2

16 years ago
It may Just Work in Windows with RTL UI. Shoshannah, do you have a machine where
you can test it?

Comment 3

16 years ago
Discussed in Mail News bug meeting, decided to minus this bug.
Keywords: nsbeta1 → nsbeta1-
Target Milestone: --- → mozilla1.2alpha
(Assignee)

Updated

16 years ago
Blocks: 137995
Product: Core → Mozilla Application Suite

Comment 4

13 years ago
(In reply to comment #2)
> It may Just Work in Windows with RTL UI.

Unless Windows with RTL UI interprets a window's x coordinates the other way
round (x=0 being the right screen edge), it won't work. The coordinates are
calculated in platform-neutral JS code, and hard-coded to be the lower right
corner (i.e. x and y near screen width and height).
(Assignee)

Comment 5

13 years ago
(In reply to comment #4)
> (In reply to comment #2)
> > It may Just Work in Windows with RTL UI.
> 
> Unless Windows with RTL UI interprets a window's x coordinates the other way
> round (x=0 being the right screen edge), it won't work.

That's what it does. See
http://www.microsoft.com/globaldev/getwr/steps/WRG_mirror.mspx

Updated

12 years ago
No longer blocks: 137995
(Assignee)

Comment 6

11 years ago
Created attachment 247669 [details] [diff] [review]
patch

I was too optimistic about this Just Working in RTL windows. It doesn't work and it's getting on my nerves. This patch will fix it for thunderbird and other toolkit apps. For Seamonkey mail, bug 345238 is also required.
Assignee: mscott → smontagu
Attachment #247669 - Flags: review?
(Assignee)

Updated

11 years ago
Attachment #247669 - Flags: review? → review?(emaijala)

Comment 7

11 years ago
Comment on attachment 247669 [details] [diff] [review]
patch

Could you prepend GetWindowLong with ::? I know it's already inconsistent, but anyway...
I couldn't actually try this, but the code looks good.
r=emaijala
Attachment #247669 - Flags: review?(emaijala) → review+
(Assignee)

Comment 8

11 years ago
Comment on attachment 247669 [details] [diff] [review]
patch

In reply to comment #7)
> Could you prepend GetWindowLong with ::?
I'll do this before checking in.
Attachment #247669 - Flags: superreview?(neil)

Comment 9

11 years ago
Comment on attachment 247669 [details] [diff] [review]
patch

>+                  // If the task bar is right-to-left, move the origin to the
>+                  // left
>+                  if (GetWindowLong(shellWindow, GWL_EXSTYLE) & WS_EX_LAYOUTRTL)
The :: is going to push the line length over 80 chars, so you might as well join the "left" on to the previous line while you're at it ;-)
Attachment #247669 - Flags: superreview?(neil) → superreview+
(Assignee)

Comment 10

11 years ago
Checked in.
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Whiteboard: [need info]
This appears to have broken the windows thunderbird build.

http://tinderbox.mozilla.org/Thunderbird/
(Assignee)

Comment 12

11 years ago
I have no idea why that should happen, since as far as I know WS_EX_LAYOUTRTL has been defined since VC 6 at least, but I checked in an "#ifndef ... #define ..." which fixed the bustage.
(Reporter)

Comment 13

11 years ago
I heard the Thunderbird trunk build has a winver set on it that it shouldn't:

See Bug 362478. We need to get that removed.
You need to log in before you can comment on or make changes to this bug.