Closed Bug 1327395 Opened 7 years ago Closed 3 years ago

Firefox handles text ".asdf." and "/.zxcv" as urls (empty domain label)

Categories

(Firefox :: Address Bar, defect, P3)

defect

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: arni2033, Unassigned)

Details

(Keywords: parity-chrome, Whiteboard: [fxsearch])

>>>   My Info:   Win7_64, Nightly 49, 32bit, ID 20160526082509
STR_1:
1. Open url [1]
2. Select text ".asdf."
3. Drag and drop it to new tab button

AR:  Browser tries to open url ".asdf."  (http://<empty domain label>.asdf/)
ER:  Browser should search for text ".asdf." in Google


STR_2:
1. Copy text "/.zxcv" to clipboard
2. Open new tab
3. Paste text in urlbar
4. Press Enter

AR:  Step 3 - urlbar shows suggestion "/.zxcv - Visit".  Step 4 - browser navigates to url "/.zxcv"
ER:  Step 3 - suggestion "/.zxcv - search with Google".  Step 4 - Browser should search text "/.zxcv"
No longer blocks: 1277113
User Agent:  Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:53.0) Gecko/20100101 Firefox/53.0

I have tested this issue on Windows 10 x64 with the latest Firefox release (50.1.0) and the latest Nightly (53.0a1-20170103030204) and managed to reproduce it.
Following the STR_2, after copying the "/.zxcv" to clipboard, opening a new tab, pasting the text in urlbar and pressing enter, the results are the same as described in the description.
Component: Untriaged → Location Bar
I suspect this is a dupe since it's not the first time I read about empty domain handling.
We pretty much depend on URIFixup to tell if the string is an URI or not

Services.uriFixup.getFixupURIInfo(".asdf.", Ci.nsIURIFixup.FIXUP_FLAG_FIX_SCHEME_TYPOS | Ci.nsIURIFixup.FIXUP_FLAG_ALLOW_KEYWORD_LOOKUP).preferredURI.spec
"http://.asdf./"

Services.uriFixup.getFixupURIInfo("/.zxcv", Ci.nsIURIFixup.FIXUP_FLAG_FIX_SCHEME_TYPOS | Ci.nsIURIFixup.FIXUP_FLAG_ALLOW_KEYWORD_LOOKUP).preferredURI.spec
"http://.zxcv/"

I don't recall if we already have a bug about empty domain handling. Though, there are also protocols allowing empty domains.
Maybe Gijs remembers that.
Flags: needinfo?(gijskruitbosch+bugs)
Priority: -- → P3
Whiteboard: [fxsearch]
Whiteboard: [fxsearch] → [fxsearch][parity-chrome]
(In reply to Marco Bonardo [::mak] from comment #2)
> I don't recall if we already have a bug about empty domain handling. Though,
> there are also protocols allowing empty domains.
> Maybe Gijs remembers that.

I don't remember off-hand, and I can't find anything relevant using search.
Flags: needinfo?(gijskruitbosch+bugs)
Mass bug change to replace various 'parity' whiteboard flags with the new canonical keywords. (See bug 1443764 comment 13.)
Keywords: parity-chrome
Whiteboard: [fxsearch][parity-chrome] → [fxsearch]

This was fixed as part of the uriFixup refactoring in bug 1496578 and friends.

Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.