1327513 - Remove Windows XP and Vista theme code from calendar

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[Richard Marti (:Paenglab)]

Gecko 53 does no more support XP and Vista.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: noXP-calendar.patch

Remove XP- and Vista code and remove images from packaging. Philipp didn't want in previous bugs I delete no more used images from tree. So I leave them.

I also changed the queries from
@media (-moz-windows-default-theme) and (-moz-os-version: ...)
to
@media (-moz-os-version: ...) and (-moz-windows-default-theme)
to be consistent with TB and toolkit.

Comment 2

[Richard Marti (:Paenglab)]

Attachment: Same patch without white space changes

For easier review I created the same patch without white space changes.

Comment 3

[[:MakeMyDay]]

Don't we need a solution for bug 1164997 before getting rid of the XP theme? You just seem to remove the icons here.

Comment 4

[Richard Marti (:Paenglab)]

The icons are unchanged for Win7 and up. I remove only the calendar-occurrence-prompt.png from packaging on Windows because now all Windows versions use calendar-occurrence-prompt-aero.png.

When I change the icons in bug 1164997, then I want to do this on all platforms. And to be honest, I forgot bug 1164997. Now it's on my radar again.

Comment 5

[Richard Marti (:Paenglab)]

Attachment: Fix-occurrence-icons-aurora.patch

I see now there is a bug in the media query in calendar-occurrence-prompt.css on aurora, beta and ESR which leads to no icon showing on Linux and macOS. On trunk the XP removal patch fixes it too.

Is it okay to add this patch here or do you want a new one?

Comment 6

[[:MakeMyDay]]

Comment on attachment 8824785 [details] [diff] [review]
Fix-occurrence-icons-aurora.patch

Review of attachment 8824785 [details] [diff] [review]:
-----------------------------------------------------------------

I would appreciate if you can move this to a separate bug as this bug is not intended to be backported.

Comment 7

[[:MakeMyDay]]

Comment on attachment 8822931 [details] [diff] [review]
noXP-calendar.patch

Review of attachment 8822931 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.

There are some incosistencies regarding the use of indentation (2 vs 4 whitespaces), but I acknowledge that this was there already before the patch. It's probably worth to be addressed in a follow-up bug to clean up the css code style wise as we did for javascript recently, although I think we don't have a linter in place for css.

Comment 8

[Richard Marti (:Paenglab)]

https://hg.mozilla.org/comm-central/rev/bb704755f3e81797b2f6566de9956277a3ac5d39