Devtools inspector - :visited links in ruleview isn't green, as defined by browser CSS

NEW
Unassigned

Status

P3
normal
2 years ago
3 months ago

People

(Reporter: arni2033, Unassigned)

Tracking

({regression})

Trunk
regression

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

2 years ago
>>>   My Info:   Win7_64, Nightly 49, 32bit, ID 20160526082509
STR_1:  (original)
1. Open https://xcraft.ru/colonization.html?sp=9
2. Inspect the left image that displays a spaceship (selector "a.terran")
3. Open ruleview, click on background url to open it in a new tab. Close that tab.

AR:  Step 2 - link in "background-url" rule is green.  Step 3 - link in "background-url" rule is blue
ER:  Either X or Y
 X) If the difference between visited and not visited links ONLY on dark theme wasn't planned, then
    The link should be green in Step 2 and Step 3.
 Y) If the difference between visited and not visited links in ruleview is intended, then
    - Visited and not visited links on light theme should look different
    - Visited links to css files in ruleview and not visited links to said files should look different


STR_2:  (testcase)
0. Visit http://example.org
1. Open url [1]
2. Inspect the 1st link
3. Inspect the 2nd link

> [1] data:text/html,<a class="h" style="background:url('http://example.org')">Example.org</a><br><a class="h" style="background:url('http://example.org/%232016.11.22 21-32-20')">Example.org Unique</a><br>


Note:
 Browser toolbox won't show you rules with ":visited" pseudoclass in ruleview - see bug 713106.
 Blue color for :visited links is hardcoded in this file:
 https://dxr.mozilla.org/mozilla-central/source/devtools/client/themes/dark-theme.css#
 Pay attention to this comment in said file, that proves that nobody did a revision since 2014-09-14:
> * FIXME: http://bugzil.la/575675 CSS links without :visited set cause assertion
> * failures in debug builds.


This illogical styling was implemented in bug 1246313. Regression range:
> https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=680574fb36ff4b2c2db6db577aba77d56b8f81d6&tochange=217746cce0e6db6caf838fb91fbccdce44746cca@ Helen V. Holmes (:helenvholmes) (:✨):
It seems that this is a regresion caused by your change. Please have a look.
Component: Untriaged → Developer Tools
Priority: -- → P3
(Reporter)

Updated

2 years ago
No longer blocks: 1277113
(Reporter)

Updated

2 years ago
Component: Developer Tools → Developer Tools: CSS Rules Inspector

Updated

3 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.