If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Disabled buttons in devtools don't show tooltip (want to know the purpose of disabled buttons)

VERIFIED FIXED in Firefox 51

Status

()

Firefox
Developer Tools
P3
normal
VERIFIED FIXED
9 months ago
8 months ago

People

(Reporter: arni2033, Assigned: Towkir, Mentored)

Tracking

({good-first-bug, regression})

51 Branch
Firefox 53
good-first-bug, regression
Points:
---

Firefox Tracking Flags

(firefox50 unaffected, firefox51 verified, firefox52 verified, firefox53 verified)

Details

(Whiteboard: [lang=css])

Attachments

(1 attachment)

(Reporter)

Description

9 months ago
>>>   My Info:   Win7_64, Nightly 52, 32bit, ID 20161028030204 (2016-10-28)
STR_1:
1. Open devtools -> inspector
2. Focus <html> node
3. Hover mouse over "+" button in inspector toolbar

AR:  No tooltip
ER:  Tooltip should appear to explain to user what does the button do and how to make it enabled


STR_2:
1. Open devtools -> memory
2. Hover mouse over button with two intersecting circles
  (As a user, I don't know what does that button represent and not aware of "compare" functionality)

AR:  No tooltip
ER:  Tooltip should appear to explain to user what does the button do and how to make it enabled


STR_3:
1. Open devtools -> debugger (old)
2. Hover mouse over button "Step over"   (okay, here I use my existing knowledge about that button,
   but current UI doesn't show what the button does)

AR:  No tooltip
ER:  Tooltip should appear to explain to user what does the button do and how to make it enabled


STR_4:  (reference of good behavior)
1. Open devtools -> debugger (new)
2. Hover mouse over button "Step over"

AR:  Tooltip appears, just as expected


This is regression from bug 1300473. Regression range:
> https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=b09dd5013cefe5d66700ca0d25ceaf821509069e&tochange=5b64b2e8e518c80e39c53aa4872e80661bd8834d@ Tim Nguyen :ntim (use needinfo?):
It seems that this is a regresion caused by your change. Please have a look.

Updated

9 months ago
Component: Untriaged → Developer Tools
Priority: -- → P3

Comment 1

9 months ago
To fix this bug, this line [0] needs to be removed

0: https://dxr.mozilla.org/mozilla-central/source/devtools/client/themes/common.css#388
Keywords: good-first-bug
Whiteboard: [lang=css]
(Reporter)

Updated

9 months ago
No longer blocks: 1277113
(Assignee)

Comment 2

9 months ago
You are right that it is necessary to explain the user what what a button does even if it is disabled, but won't it create confusion if someone can see the tooltip ? (will think the button will work on clicking) 
Here comes the part of explanation on how to enable the button and currently it is disabled. 
Then comes the change on the tooltips if the buttons are enabled or disabled [different tooltips for different states]

For now I will submit a patch with this solution only :)
Assignee: nobody → 3ugzilla
Status: NEW → ASSIGNED
(Assignee)

Comment 3

9 months ago
Hi Tim, I hope you have no problem reviewing this one :)
Mentor: ntim.bugs@gmail.com
(Assignee)

Comment 4

9 months ago
Created attachment 8822980 [details] [diff] [review]
disabled_buttons_tooltip.patch

Hope this helps :)
Attachment #8822980 - Flags: review?(ntim.bugs)

Comment 5

9 months ago
Comment on attachment 8822980 [details] [diff] [review]
disabled_buttons_tooltip.patch

Review of attachment 8822980 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! I agree it'd be nice to explain how to enable the button in the tooltip, but I think this can be a bug on its own.
Attachment #8822980 - Flags: review?(ntim.bugs) → review+
(Assignee)

Comment 6

9 months ago
(In reply to Tim Nguyen :ntim (use needinfo?) from comment #5)
> but I think this can be a bug on its own.
I was also thinking something like that. I would be glad to know about / work on that bug if you report any.
Keywords: checkin-needed

Comment 7

9 months ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/27936d2241b3
Disabled buttons in devtools now do show tooltips. r=ntim
Keywords: checkin-needed

Comment 8

9 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/27936d2241b3
Status: ASSIGNED → RESOLVED
Last Resolved: 9 months ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
Please request Aurora/Beta approval on this when you get a chance.
status-firefox50: --- → unaffected
status-firefox51: --- → affected
status-firefox52: --- → affected
Flags: needinfo?(3ugzilla)
Version: Trunk → 51 Branch

Comment 10

9 months ago
Comment on attachment 8822980 [details] [diff] [review]
disabled_buttons_tooltip.patch

Approval Request Comment
[Feature/Bug causing the regression]: bug 1300473
[User impact if declined]: no tooltip on disabled buttons
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]:  no
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no
[Why is the change risky/not risky?]: small css change
[String changes made/needed]: no
Flags: needinfo?(3ugzilla)
Attachment #8822980 - Flags: approval-mozilla-beta?
Attachment #8822980 - Flags: approval-mozilla-aurora?

Updated

9 months ago
status-firefox53: fixed → verified
(Assignee)

Comment 11

8 months ago
I was a little busy. Thanks Tim :)
Comment on attachment 8822980 [details] [diff] [review]
disabled_buttons_tooltip.patch

show tooltips even for disabled buttons in devtools, aurora52+
Attachment #8822980 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment on attachment 8822980 [details] [diff] [review]
disabled_buttons_tooltip.patch

Adds a tooltip, simple fix, OK to uplift to beta.
Attachment #8822980 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Comment 14

8 months ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/072acb55b669
status-firefox52: affected → fixed

Comment 15

8 months ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-beta/rev/a82694b0700b
status-firefox51: affected → fixed
QA Whiteboard: [good first verify]
Verified fixed on User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:53.0) Gecko/20100101 Firefox/53.0
Status: RESOLVED → VERIFIED

Comment 17

8 months ago
I have reproduced this issue on Nightly 52, 2016.10.28, under Ubuntu 14.04 64 bit.
I verified as fixed on latest Aurora 52.0a2, 2017.01.15 and Firefox 51.0b14, under ubuntu 14.04 64 bit,
Win 10 64 bit, and Mac OS X 10.11.6.
status-firefox51: fixed → verified
status-firefox52: fixed → verified
You need to log in before you can comment on or make changes to this bug.