1327999 - Focus outline in devtools buttons is different than outline in tabs

Status: NEW

(DevTools :: Framework, defect, P3)

Description

[arni2033]

>>>   My Info:   Win7_64, Nightly 53, 32bit, ID 20161119030204 (2016-11-19)
STR_1:
1. Open url   data:,
2. Click on the page, then press Tab key to focus element picker button
3. Press Right key to focus inspector tab

AR:
 Focus outline in buttons on devtools toolbar isn't consistent with focus outline in devtools tabs:
 focus outline in tabs is placed right near the borders of the tab rectangle,
 but buttons have some indent between focus outline and the visual borders of the button
ER: 
 Focus outline should have the same "layout" as in tabs

This is regression from bug 1286872. Regression range:
> https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=6b9dae7e278dcd38d0b1c221ca9420931dfac7fd&tochange=626f03d8438fb7f7bbc778d80672037bd95ac0f7@ Tim Nguyen :ntim (use needinfo?):
It seems that this is a regresion caused by your change. Please have a look.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

:bgrins, any opinions on this one?  Not sure how severe it is / whether it warrants regression tracking.

Comment 2

[Brian Grinstead [:bgrins]]

Attachment: focus-command-button-outline.png

It doesn't warrant regression tracking, but it's a valid polish item.  Attaching a screenshot for future reference.  The dotted outline should go all the way up to the top and bottom of the tab bar