1328043 - Iframe isn't scrolled into view when I focus it

Status: VERIFIED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[arni2033]

>>>   My Info:   Win7_64, Nightly 49, 32bit, ID 20160526082509
STR_1:
1. Open url   data:text/html,<button>B</button><br><iframe style="margin-top:10000px;height:400px">
2. Click on button "B"
3. Press Tab key once

AR:  Focused iframe is not scrolled into view
ER:  The iframe should be scrolled into view

Note:
 This usually happens on the page with a left and right "columns" with content. The left one is the
 article/comments/youtube video, and the right one contains some related links, but starts with iframe
 When I press Tab key to navigate to the last link/focusable item in the left column, then press Tab
 once again, nothing happens. Focusring just disappears from visible part of the page.

This is regression from bug 178324 (between 2009-06-10 and 2009-06-11). Regression range:
> http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=90d3e6d2cbb9&tochange=4430cae50dad@ Neil Deakin:
It seems that this is a regresion caused by your change. Please have a look.

Comment 1

[Emil Pasca [:emilpasca]]

User Agent:  Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:53.0) Gecko/20100101 Firefox/53.0

I have tested this issue on Windows 10 x64 with the latest Firefox release (50.1.0) and the latest Nightly (53.0a1-20170103030204) and managed to reproduce it.
After following the STR_1, when pressing the tab key once the iframe isn't scrolled into view.

Neil, can you please take a look at this?

Comment 2

[Neil Deakin]

Attachment: Move scrolling code

Comment 3

[Neil Deakin]

https://hg.mozilla.org/integration/mozilla-inbound/rev/15748795cb4b4450cbb198b030af29b7f273d46e
Bug 1328043, scrolling into view on focus should happen even when event shouldn't fire, fixes tabbing into blank iframes, r=smaug

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/15748795cb4b

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Emil, can you please verify that this issue is fixed with the next Nightly? Thanks!

Comment 6

[Emil Pasca [:emilpasca]]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:53.0) Gecko/20100101 Firefox/53.0

The issue is no longer reproducible on the latest Nightly (53.0a1-20170110030221).

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Thanks, Emil!

Hi Neil, can you please request Aurora (and Beta if suitable) approval on this? Thanks!

Comment 8

[Neil Deakin]

This bug has existed for at least 8 years, so I don't see why that is necessary.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Fair enough, thanks.