1328104 - Add Search Engine Button Does Not Work

Status: RESOLVED DUPLICATE of bug 1323525

(Firefox :: Search, defect, P1)

Description

[davidpost-1]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:53.0) Gecko/20100101 Firefox/53.0
Build ID: 20170101030204

Steps to reproduce:

1. Visit a search engine that is not currently installed in firefox.
2. In firefox's search bar, the magnifying glass should have a green "+" symbol. Click the magnifying glass.
3. Click "Add ... " to add the search engine.


Actual results:

The search engine is not added. There appears to be no change to any search preferences.

This problem has been replicated in a clean profile and by others on the nightly IRC.


Expected results:

A new search engine should have been added.

Comment 1

[Loic]

WFM with the latest FF53 on Win 7. Is it specific to Linux?
Could you run mozregression to narrow down a regression range, please.
http://mozilla.github.io/mozregression/

Comment 2

[YF (Yang)]

WFM with build 20170101030204 on Win10, added work on https://www.baidu.com/.

Comment 3

[davidpost-1]

(In reply to Loic from comment #1)
> WFM with the latest FF53 on Win 7. Is it specific to Linux?
> Could you run mozregression to narrow down a regression range, please.
> http://mozilla.github.io/mozregression/


I haven't tried on windows.
I've run mozregression on linux and the final output is as follows.

29:05.29 INFO: Looks like the following bug has the changes which introduced the regression:
https://bugzilla.mozilla.org/show_bug.cgi?id=1113747

Comment 4

[Hussam Al-Tayeb]

Same issue here on Linux.

Comment 5

[Marcia Knous [:marcia - needinfo? me/PTO 12/6-12/12)]]]

We can track this for 53, but we should also check to see if this bug is a dupe of one of the other bugs on file - Bug 1323525 for example is very similar. It seems as if there are a number of search selections not working in Linux.

Comment 7

[Cristian Comorasu, QA [:ccomorasu], Release Desktop QA]

[Regression range]:
 Last good revision: 55a41c5e8e88010ea8a539c009f27b7b14988700
 First bad revision: 3e92691272d3139d0f428bf7499bc65f7318f540
 Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=55a41c5e8e88010ea8a539c009f27b7b14988700&tochange=3e92691272d3139d0f428bf7499bc65f7318f540

 Looks like the following bug has the changes which introduced the regression:
https://bugzilla.mozilla.org/show_bug.cgi?id=1113747

Comment 8

[Loic]

Regression range has been already established in comment #3. ;)

Comment 9

[Drew Willcoxon :adw]

This is the same problem as bug 1323525 and is fixed by the patch there.

Comment 10

[Sayed [:LiquidO2]]

I have reproduced this bug with Nightly 53.0a1 (2017-01-01) (64-bit) on Manjaro 16 64bit.

Verified as fixed with Latest Nightly 54.0a1

Build ID 	20170202110108
User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:54.0) Gecko/20100101 Firefox/54.0

Comment 11

[Cristian Comorasu, QA [:ccomorasu], Release Desktop QA]

I can confirm comment 10. I will set the flag accordingly.

Comment 12

[Drew Willcoxon :adw]

I'm just going to dupe this to bug 1323525 instead of continuing to copy all the status flags, etc.  They're different bugs but they have exactly the same cause.

Comment 13

[Liz Henry (:lizzard)]

Fixed in 53 in the duplicate bug.

Comment 14

[Cristian Comorasu, QA [:ccomorasu], Release Desktop QA]

This issue is no longer reproducible. I verified using Fx 52.0b3 on Ubuntu 14.04 LTS x 64.

Comment 15

[Jan Tojnar]

I am still able to reproduce this on nightly 2017-03-20 (Linux), the bug 1323525 is fixed for me though.

Comment 16

[Loic]

Drew, do we need to reopen this bug?

Comment 17

[Panos Astithas (he/him) [:past] (please ni?)]

Please file a new bug, this is a new regression in 55. It would be very helpful if we could get a regression window as well.