accesskey 'o' used twice in Tools menu on Windows: for Options and Developer Tools

RESOLVED FIXED in Thunderbird 53.0

Status

Thunderbird
General
RESOLVED FIXED
11 months ago
11 months ago

People

(Reporter: aryx, Assigned: aryx)

Tracking

unspecified
Thunderbird 53.0

Thunderbird Tracking Flags

(thunderbird51 unaffected, thunderbird52 fixed, thunderbird53 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Thunderbird 53.0a1 20170102030205 and 52.0a2 20170102004003 (both 32-bit) on Windows 8.1 64-bit

The accesskey 'o' is used twice in the Tools menu on Windows: for Options and Developer Tools.
Created attachment 8823122 [details] [diff] [review]
patch for comm-central, v1
Attachment #8823122 - Flags: review?(richard.marti)
Created attachment 8823123 [details] [diff] [review]
patch for C-C and C-A, v1
Attachment #8823123 - Flags: review?(richard.marti)
Comment on attachment 8823122 [details] [diff] [review]
patch for comm-central, v1

r=me if you think we need to change the entity names. Other locales may not have this conflict like de for example which uses "_E_instellungen" now (the new accesskey would now conflict with this ;) ). If you think, this should change for the translators as a heads-up, then okay. If not, we could also only use the aurora patch. You are deeper involved in translations and can decide whats better.
Attachment #8823122 - Flags: review?(richard.marti) → review+

Updated

11 months ago
Attachment #8823123 - Flags: review?(richard.marti) → review+

Comment 4

11 months ago
Comment on attachment 8823123 [details] [diff] [review]
patch for C-C and C-A, v1

I've been told that access key changes don't need new strings.

So can we please use the "Aurora" patch for C-C as well. Would you like me to land this with some other stuff?
Attachment #8823123 - Flags: approval-comm-aurora+

Comment 5

11 months ago
Comment on attachment 8823122 [details] [diff] [review]
patch for comm-central, v1

Sebastian, are you OK with landing the simple Aurora patch on C-C as well? If not, can you please state why you changed the string IDs. IMHO it's not necessary (if it were, it would be even more necessary for Aurora) and it leads to unnecessary re-translation of the identical string "Developer Tools".
Flags: needinfo?(aryx.bugmail)
Attachment #8823122 - Flags: feedback-
Feel free to land the aurora version on both branches.
Flags: needinfo?(aryx.bugmail)

Updated

11 months ago
Attachment #8823122 - Attachment is obsolete: true

Updated

11 months ago
Attachment #8823123 - Attachment description: patch for comm-aurora, v1 → patch for C-C and C-A, v1

Comment 7

11 months ago
Thanks, I'll land this after the next M-C merge.
Keywords: checkin-needed

Comment 8

11 months ago
https://hg.mozilla.org/comm-central/rev/614e97c63b00c526c59a03cd261886d508ca3d97
Status: ASSIGNED → RESOLVED
Last Resolved: 11 months ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 53.0

Comment 9

11 months ago
Aurora (TB 52):
https://hg.mozilla.org/releases/comm-aurora/rev/9b2680b7eb92d136fd52b6ba5575ad8592637773
status-thunderbird52: affected → fixed
status-thunderbird53: affected → fixed
You need to log in before you can comment on or make changes to this bug.