132817 - Chatzilla has problems joining pirc server

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, defect)

Description

[Tim Powell]

This is perhaps a problem with the pirc server (pircd Beta Zero - see
http://pircd.sourceforge.net/ ) but chatzilla should handle it better. When
connecting to the server, chatzilla gives this response:

[INFO]Network view for ``irc.xxxxxxx.com'' opened.
[INFO]Attempting to connect to ``irc.xxxxxxx.com''. Use /cancel to abort.
[INFO]Connecting to irc.xxxxxxx.com via irc.xxxxxxx.com:6667, attempt 1 of 5...
===PING: Unknown command
===Welcome to the Internet Relay Network tpowell
===Your host is irc.yyyy.org, running version pircd-beta-0
===This server was created Fri Mar 22 15:34:25 2002
===irc.yyyy.org pircd-beta-0 dioswkg biklmnopstv
===There are 7 users and 0 invisible on 1 server(s)
===0 operator(s) online
===I have 7 user(s) and 0 server(s)
===- irc.yyyy.org Message of the Day -
===- irc.yyyy.org running pircd (pircd.sourceforge.net)
===- Yes, this IRC server is in Perl.
===- If you can't do it in Perl, you don't want to do it.
---End of /MOTD command.

Then when joining a channel, it joins the correct channel and creates a tab for
the channel, showing messages like this:

[INFO]Channel view for ``#moz'' opened.
===5: channels formed
===Highest connection count: 7 (7 clients)
=-=Topic for #moz is ``Chatzilla rocks!''
=-=Topic for #moz was set by theuiguy on Thu Mar 21 2002 22:35:07 GMT-0500
(Eastern Standard Time)

It also seems to join a null channel and creates an unlabeled tab with messages
like this:

-->|YOU have joined 
===: No such channel.

This last tab also shows user join and leave messages for the channels and the
user list in the channel tabs do not update correctly. I can't seem to close
this unlabeled tab (leave channel from the context menu doesn't do anything).

Eventually chatzilla drops the connection. Sometimes other users on the channel
see a ping flood message for the chatzilla user.

Comment 1

[Samuel Sieb]

Some of these issues are from chatzilla and some from pircd.  One thing you
missed is on the console, chatzilla dumps an error, because the server sends an
empty line.  The ping error seems to be that the server won't accept a ping
request while the logging in processing is happening.  For some reason,
chatzilla sends "MODE " to the server on joining a channel (perhaps because the
server didn't send the mode info?).  This is what creates the blank tab.  But I
don't know why joins and parts go to the blank tab as well.  And occasionly I
will get a crash on exit.  I haven't yet seen the dropped connection or ping
flood (maybe specific to your server (and I don't know where that is)).

Comment 2

[Samuel Sieb]

I think you missed my comments on irc.
We found out why we were getting the extra channel.  It's because the server is
sending an unexpected (but valid) form of join message.  Checking the code, it
looks like it should be fixed.

What problems are you seeing?

Comment 3

[Tim Powell]

I'm getting the same behavior as originally reported except that I'm no longer 
getting ping flood dropouts. Joining the channel causes an extra blank tab to 
appear and join/leave messages are shown in that tab.

You can try it yourself. I've added the URL.

Comment 4

[Samuel Sieb]

I don't see the problem, it works for me.  What versions of chatzilla and
mozilla are you using?

Comment 5

[Basil Fritts]

Using 2002091908-trunk (Mac OS 10.2 and Red Hat Linux 7.2), I see the problem as
described in original report, as ammended in comment #3.

Comment 6

[Samuel Sieb]

Attachment: fix the blank channel

The fix was in my tree, not the mozilla tree. :-)

Comment 7

[Tim Powell]

Thank you, thank you. The patch works great. Check it in. :-)

Comment 8

[Robert Ginda]

Comment on attachment 99929 [details] [diff] [review]
fix the blank channel

r=rginda

Comment 9

[Samuel Sieb]

checked in