Closed Bug 1328227 Opened 3 years ago Closed 3 years ago

CacheIR: add payload register to availableRegs_ in useValueRegister

Categories

(Core :: JavaScript Engine: JIT, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: jandem, Assigned: jandem)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
evilpie, this should fix the assertion failure you saw on x86 on Try with the previous version of your patch. When we box a PayloadReg to a ValueReg, we should add the payload register to availableRegs_ as it's unused after that.

We could optimize this code, especially on 64-bit platforms we can just reuse the register without allocating any new registers, but this case isn't super common yet so I didn't bother for now.
Attachment #8823193 - Flags: review?(evilpies)
Comment on attachment 8823193 [details] [diff] [review]
Patch

Review of attachment 8823193 [details] [diff] [review]:
-----------------------------------------------------------------

Good catch. Sorry about not seeing that during review.
Attachment #8823193 - Flags: review?(evilpies) → review+
Priority: -- → P1
Pushed by jandemooij@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4aca941d2d3b
Add payload register to availableRegs_ in useValueRegister. r=h4writer
https://hg.mozilla.org/mozilla-central/rev/4aca941d2d3b
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.