Closed
Bug 1328227
Opened 7 years ago
Closed 7 years ago
CacheIR: add payload register to availableRegs_ in useValueRegister
Categories
(Core :: JavaScript Engine: JIT, defect, P1)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla53
| Tracking | Status | |
|---|---|---|
| firefox53 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
989 bytes,
patch
|
h4writer
:
review+
|
Details | Diff | Splinter Review |
evilpie, this should fix the assertion failure you saw on x86 on Try with the previous version of your patch. When we box a PayloadReg to a ValueReg, we should add the payload register to availableRegs_ as it's unused after that. We could optimize this code, especially on 64-bit platforms we can just reuse the register without allocating any new registers, but this case isn't super common yet so I didn't bother for now.
Attachment #8823193 -
Flags: review?(evilpies)
|
||
Comment 1•7 years ago
|
||
Comment on attachment 8823193 [details] [diff] [review] Patch Review of attachment 8823193 [details] [diff] [review]: ----------------------------------------------------------------- Good catch. Sorry about not seeing that during review.
Attachment #8823193 -
Flags: review?(evilpies) → review+
|
Assignee | |
Updated•7 years ago
|
Priority: -- → P1
Pushed by jandemooij@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/4aca941d2d3b Add payload register to availableRegs_ in useValueRegister. r=h4writer
|
||
Comment 3•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/4aca941d2d3b
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in
before you can comment on or make changes to this bug.
Description
•