Closed
Bug 1328229
Opened 7 years ago
Closed 7 years ago
Remove the layer dependency in SampleAnimation
Categories
(Core :: Graphics: WebRender, defect)
Core
Graphics: WebRender
Tracking
()
RESOLVED
FIXED
mozilla53
Tracking | Status | |
---|---|---|
firefox53 | --- | fixed |
People
(Reporter: pchang, Assigned: pchang)
References
Details
(Whiteboard: [gfx-noted])
Attachments
(1 file, 1 obsolete file)
Add sampleanimation support in WebRenderBridgeParent to support OMTA
Assignee | ||
Updated•7 years ago
|
Assignee | ||
Comment 1•7 years ago
|
||
Inside AsyncCompositionManager.cpp, we need to remove the layer dependency from the static function 'SampleAnimation' and 'ApplyAnimatedValue'. After we doing this, we can share these logic with CompositorBridgeParent and WebRenderBridgeParent.
Assignee: nobody → howareyou322
Whiteboard: [gfx-noted]
Assignee | ||
Comment 2•7 years ago
|
||
MozReview-Commit-ID: 78D3c7t8tIi
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Attachment #8825329 -
Attachment is obsolete: true
Assignee | ||
Comment 4•7 years ago
|
||
(In reply to Peter Chang[:pchang] from comment #1) > Inside AsyncCompositionManager.cpp, we need to remove the layer dependency > from the static function 'SampleAnimation' and 'ApplyAnimatedValue'. After > we doing this, we can share these logic with CompositorBridgeParent and > WebRenderBridgeParent. Brian, as I mentioned above, we would like to support OMTA for Quantum Render which doesn't have layer information in the Parent side(WebRenderBridgeParent). Therefore, I have to do the refactor for the SampleAnimation function.
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8825623 [details] Bug 1328229 - Remove the layer dependency for SampleAnimation, https://reviewboard.mozilla.org/r/103740/#review104462 ::: gfx/layers/composite/AsyncCompositionManager.cpp:778 (Diff revision 1) > - computedTiming.mCurrentIteration, > + computedTiming.mCurrentIteration, > - animationValue); > - hasInEffectAnimations = true; > + aAnimationValue); > + aHasInEffectAnimations = true; > - } > + } > > -#ifdef DEBUG > + #ifdef DEBUG MozReview is suggesting this line and the following #endif are indented a space. Is that intentional? ::: gfx/layers/composite/AsyncCompositionManager.cpp:811 (Diff revision 1) > +{ > + bool activeAnimations = false; > + > + ForEachNode<ForwardIterator>( > + aLayer, > + [&activeAnimations, aPoint] (Layer* layer) Is dropping the reference semantics for aPoint intentional?
Attachment #8825623 -
Flags: review?(bbirtles) → review+
Assignee | ||
Comment 6•7 years ago
|
||
mozreview-review-reply |
Comment on attachment 8825623 [details] Bug 1328229 - Remove the layer dependency for SampleAnimation, https://reviewboard.mozilla.org/r/103740/#review104462 > MozReview is suggesting this line and the following #endif are indented a space. Is that intentional? The space should be removed. > Is dropping the reference semantics for aPoint intentional? This should be typo error. Fixed.
Comment hidden (mozreview-request) |
Assignee | ||
Comment 8•7 years ago
|
||
I would like to land this bug first and create another bug to call new SampleAnimationForEachNode in WebRenderBridgeParent.
No longer depends on: 1325022
Summary: Add sampleanimation support in WebRenderBridgeParent → Remove the layer dependency in SampleAnimation
Pushed by pchang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/642f5d4cf6fc Remove the layer dependency for SampleAnimation, r=birtles
Comment 10•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/642f5d4cf6fc
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in
before you can comment on or make changes to this bug.
Description
•