Create consolidated masthead navigation [pebbles]

NEW
Unassigned

Status

www.mozilla.org
Pages & Content
10 months ago
10 months ago

People

(Reporter: agibson, Unassigned)

Tracking

Production

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

10 months ago
When updating the main navigation on pages that feature the new style masthead [1], [2], [3], we seem to have a fair amount of duplication going on which we could probably tidy up and consolidate.

Each page imports `_masthead.scss`, but then overwrites a set of very similar additional styles to incorporate things like the download button. We could probably consolidate this styling all into `_masthead.scss` to avoid repeating it for each page.

The three pages also import their own shared implementation of the nav HTML [4], overwriting what's already in `base-pebbles.html`. We could potentially just make this the default in the base-pebbles template, which would make all other pebbles pages (such as the /about/leadership/ page) feature the same unified masthead and reduce more individual page styling. Pages could still hide the download button when required.

[1] https://www.mozilla.org/en-US/
[2] https://www.mozilla.org/en-US/technology/
[3] https://www.mozilla.org/en-US/internet-health/
[4] https://github.com/mozilla/bedrock/blob/master/bedrock/mozorg/templates/mozorg/home/includes/nav.html

Comment 1

10 months ago
+1! We definitely need to consolidate this into a single component, assuming we have consensus on the content and presentation of that component.
You need to log in before you can comment on or make changes to this bug.