1328257 - Perma failure in browser_webconsole_bug_595223_file_uri.js when Gecko 53 moves to Aurora

Status: RESOLVED FIXED

(DevTools :: Console, defect)

Description

[Carsten Book [:Tomcat]]

https://treeherder.mozilla.org/logviewer.html#?job_id=65820865&repo=try was found when i did trunk as aurora uplift simulation. Seems this is a perma failure in Linux, OS X and Windows.

So we need to fix this before merge to avoid tree closings after merge day

Comment 1

[Carsten Book [:Tomcat]]

[Tracking Requested - why for this release]:

Bob, seems you touched this test in Bug 1147911, could you take a look ?

Comment 2

[Bob Owen (:bobowen)]

Ah yes, looks like I need to allow for the pref to be false, I'll get to this soon.

Comment 3

[Marcia Knous [:marcia]]

Tracking 53+ so we get to this before the merge.

Comment 4

[Bob Owen (:bobowen)]

Try push with file content process enabled:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=54a1697d392778a6cc68cb3a629fc7de2ba48e96

Try push with file content process disabled:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=17ae07c6a9f040b3013055d1bff25cc38dc80d6d

Comment 5

[Bob Owen (:bobowen)]

Attachment: Fix browser_webconsole_bug_595223_file_uri.js test when separate file content process disabled

I hadn't allowed for when the file content process is not enabled.
This uses the standard function to get the remote type, so should always work no matter what the settings.

MozReview-Commit-ID: IeC00eWt3fm

Comment 6

[Alexandre Poirot [:ochameau]]

Comment on attachment 8825074 [details] [diff] [review]
Fix browser_webconsole_bug_595223_file_uri.js test when separate file content process disabled

Review of attachment 8825074 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the fix!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2ac52f6d2565
Fix browser_webconsole_bug_595223_file_uri.js test when separate file content process disabled. r=ochameau

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/2ac52f6d2565