Closed Bug 1328257 Opened 5 years ago Closed 5 years ago

Perma failure in browser_webconsole_bug_595223_file_uri.js when Gecko 53 moves to Aurora

Categories

(DevTools :: Console, defect)

defect
Not set
blocker

Tracking

(firefox51 unaffected, firefox52 unaffected, firefox53+ fixed)

RESOLVED FIXED
Firefox 53
Tracking Status
firefox51 --- unaffected
firefox52 --- unaffected
firefox53 + fixed

People

(Reporter: cbook, Assigned: bobowen)

References

()

Details

Attachments

(1 file)

https://treeherder.mozilla.org/logviewer.html#?job_id=65820865&repo=try was found when i did trunk as aurora uplift simulation. Seems this is a perma failure in Linux, OS X and Windows.

So we need to fix this before merge to avoid tree closings after merge day
[Tracking Requested - why for this release]:

Bob, seems you touched this test in Bug 1147911, could you take a look ?
Flags: needinfo?(bobowencode)
Ah yes, looks like I need to allow for the pref to be false, I'll get to this soon.
Assignee: nobody → bobowencode
Status: NEW → ASSIGNED
Tracking 53+ so we get to this before the merge.
I hadn't allowed for when the file content process is not enabled.
This uses the standard function to get the remote type, so should always work no matter what the settings.

MozReview-Commit-ID: IeC00eWt3fm
Attachment #8825074 - Flags: review?(poirot.alex)
Comment on attachment 8825074 [details] [diff] [review]
Fix browser_webconsole_bug_595223_file_uri.js test when separate file content process disabled

Review of attachment 8825074 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the fix!
Attachment #8825074 - Flags: review?(poirot.alex) → review+
Pushed by bobowencode@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2ac52f6d2565
Fix browser_webconsole_bug_595223_file_uri.js test when separate file content process disabled. r=ochameau
https://hg.mozilla.org/mozilla-central/rev/2ac52f6d2565
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.