All users were logged out of Bugzilla on October 13th, 2018

Perma failure in browser_webconsole_bug_595223_file_uri.js when Gecko 53 moves to Aurora

RESOLVED FIXED in Firefox 53

Status

--
blocker
RESOLVED FIXED
2 years ago
4 months ago

People

(Reporter: cbook, Assigned: bobowen)

Tracking

unspecified
Firefox 53

Firefox Tracking Flags

(firefox51 unaffected, firefox52 unaffected, firefox53+ fixed)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
https://treeherder.mozilla.org/logviewer.html#?job_id=65820865&repo=try was found when i did trunk as aurora uplift simulation. Seems this is a perma failure in Linux, OS X and Windows.

So we need to fix this before merge to avoid tree closings after merge day
(Reporter)

Comment 1

2 years ago
[Tracking Requested - why for this release]:

Bob, seems you touched this test in Bug 1147911, could you take a look ?
tracking-firefox53: --- → ?
Flags: needinfo?(bobowencode)
(Assignee)

Comment 2

2 years ago
Ah yes, looks like I need to allow for the pref to be false, I'll get to this soon.
Assignee: nobody → bobowencode
Status: NEW → ASSIGNED
Tracking 53+ so we get to this before the merge.
tracking-firefox53: ? → +
(Assignee)

Comment 4

2 years ago
Try push with file content process enabled:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=54a1697d392778a6cc68cb3a629fc7de2ba48e96

Try push with file content process disabled:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=17ae07c6a9f040b3013055d1bff25cc38dc80d6d
Flags: needinfo?(bobowencode)
(Assignee)

Comment 5

2 years ago
Created attachment 8825074 [details] [diff] [review]
Fix browser_webconsole_bug_595223_file_uri.js test when separate file content process disabled

I hadn't allowed for when the file content process is not enabled.
This uses the standard function to get the remote type, so should always work no matter what the settings.

MozReview-Commit-ID: IeC00eWt3fm
Attachment #8825074 - Flags: review?(poirot.alex)
Comment on attachment 8825074 [details] [diff] [review]
Fix browser_webconsole_bug_595223_file_uri.js test when separate file content process disabled

Review of attachment 8825074 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the fix!
Attachment #8825074 - Flags: review?(poirot.alex) → review+

Comment 7

2 years ago
Pushed by bobowencode@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2ac52f6d2565
Fix browser_webconsole_bug_595223_file_uri.js test when separate file content process disabled. r=ochameau

Comment 8

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/2ac52f6d2565
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
status-firefox51: --- → unaffected
status-firefox52: --- → unaffected
Keywords: intermittent-failure

Updated

4 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.