Closed Bug 1328273 Opened 3 years ago Closed 2 years ago

Fix error messages logged at the info level in mozrunner

Categories

(Testing :: Mozbase, defect)

defect
Not set

Tracking

(firefox61 fixed)

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: ahal, Assigned: ahal)

Details

Attachments

(1 file, 1 obsolete file)

After the leak fiasco I did a quick check to see if there are any other places we are doing log.info('TEST-UNEXPECTED-FAIL'), and found two instances in utils.py in mozrunner.

Afaict, no bustage has landed as a result, but it still needs to get fixed. After this, the only place this error still happens is in the automation.py files, which are no longer being used.
Comment on attachment 8823257 [details]
Bug 1328273 - Log mozrunner.utils failure messages at the error level,

https://reviewboard.mozilla.org/r/101820/#review102228
Attachment #8823257 - Flags: review?(james) → review+
Huh, this never landed and looks like it's still a problem. I must have forgotten to autoland.
Attachment #8823257 - Attachment is obsolete: true
Sorry, I had to re-create the commit because pulling it down from mozreview was erroring out for some reason (too old maybe?). Even though I made the commit message the same, it decided to reflag you instead of carrying the r+ forward.
Comment on attachment 8965114 [details]
Bug 1328273 - Log mozrunner.utils failure messages at the error level,

https://reviewboard.mozilla.org/r/233804/#review239708
Attachment #8965114 - Flags: review?(james) → review+
Pushed by ahalberstadt@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/593504e33d9b
Log mozrunner.utils failure messages at the error level, r=jgraham
https://hg.mozilla.org/mozilla-central/rev/593504e33d9b
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.