Closed
Bug 1328280
Opened 7 years ago
Closed 7 years ago
"Finish Review" text should move to fork, not JavaScript
Categories
(MozReview Graveyard :: Review Board: User Interface, defect)
MozReview Graveyard
Review Board: User Interface
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: davidwalsh, Assigned: davidwalsh)
Details
Attachments
(3 files, 2 obsolete files)
Now that we have the RB fork, we can change the "Review" text to "Finish Review" without a JavaScript hack to do so.
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
Assignee | |
Comment 4•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8823274 [details] MozReview: Remove legacy 'Finish Review...' setter. (Bug 1328280) https://reviewboard.mozilla.org/r/101838/#review102250 This also includes a few ESLint config fixes.
|
|
Assignee | |
Comment 5•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8823272 [details] MozReview: Add 'review_request_actions_primary_mozreview.html' in anticipation for template changes. (Bug 1328280) https://reviewboard.mozilla.org/r/101832/#review102252 This changeset got corrupted during rebase -- please give me a moment to fix.
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8823272 -
Attachment is obsolete: true
Attachment #8823272 -
Flags: review?(smacleod)
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8823273 -
Attachment is obsolete: true
Attachment #8823273 -
Flags: review?(smacleod)
|
||
Comment 8•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8823274 [details] MozReview: Remove legacy 'Finish Review...' setter. (Bug 1328280) https://reviewboard.mozilla.org/r/101838/#review103648
Attachment #8823274 -
Flags: review?(smacleod) → review+
|
|
||
Comment 9•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8823285 [details] MozReview: Add 'review_request_actions_primary_mozreview.html' in anticipation for template changes. (Bug 1328280) https://reviewboard.mozilla.org/r/101844/#review103650
Attachment #8823285 -
Flags: review?(smacleod) → review+
|
|
||
Comment 10•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8823286 [details] MozReview: Change 'Review' link to 'Finish Review...' (Bug 1328280) https://reviewboard.mozilla.org/r/101846/#review103652
Attachment #8823286 -
Flags: review?(smacleod) → review+
|
||
Comment 11•7 years ago
|
||
Pushed by smacleod@mozilla.com: https://hg.mozilla.org/hgcustom/version-control-tools/rev/98c077a78324 MozReview: Remove legacy 'Finish Review...' setter. r=smacleod
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
|
|
||
Comment 12•7 years ago
|
||
Pushed by smacleod@mozilla.com: https://hg.mozilla.org/webtools/reviewboard/rev/b78120ce7ec6 MozReview: Add 'review_request_actions_primary_mozreview.html' in anticipation for template changes. r=smacleod https://hg.mozilla.org/webtools/reviewboard/rev/4dbe2886b9cf MozReview: Change 'Review' link to 'Finish Review...' r=smacleod
|
||
Updated•7 years ago
|
Assignee: nobody → dwalsh
You need to log in
before you can comment on or make changes to this bug.
Description
•