1328353 - Exception: Ansible did not run on rbweb successfully

Status: RESOLVED FIXED

(MozReview Graveyard :: Testing / Development Environment, defect)

Description

[David Walsh :davidwalsh]

With 454aa6aedeb3 checked out, I'm unable to run `./create-test-environment` successfully.  I'm on docker version 1.12.0, python version 2.7.12.  Stack trace is:

```
hgweb> PLAY RECAP ********************************************************************
hgweb> localhost                  : ok=117  changed=93   unreachable=0    failed=0
Error running mach:

    ['build-all']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.

You should consider filing a bug for this issue.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

Exception: Ansible did not run on rbweb successfully

  File "/Users/dwalsh/Projects/version-control-tools/testing/vcttesting/docker_mach_commands.py", line 96, in build_all
    self.d.build_all_images(verbose=True, max_workers=forks)
  File "/Users/dwalsh/Projects/version-control-tools/testing/vcttesting/docker.py", line 1439, in build_all_images
    use_last=use_last)
  File "/Users/dwalsh/Projects/version-control-tools/testing/vcttesting/docker.py", line 662, in ensure_images_built
    name, image = f.result()
  File "/Users/dwalsh/Projects/version-control-tools/venv/lib/python2.7/site-packages/concurrent/futures/_base.py", line 398, in result
    return self.__get_result()
  File "/Users/dwalsh/Projects/version-control-tools/venv/lib/python2.7/site-packages/concurrent/futures/thread.py", line 55, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/Users/dwalsh/Projects/version-control-tools/testing/vcttesting/docker.py", line 621, in build_ansible
    verbose=verbose)
  File "/Users/dwalsh/Projects/version-control-tools/testing/vcttesting/docker.py", line 748, in run_ansible
    repository)
You will not be able to run tests that require Docker.
Please see https://docs.docker.com/installation/ for how to install Docker.
When Docker is installed, re-run this script
```

Comment 1

[Mark Côté [:mcote]]

You should have some "rbweb" messages in your log further up.  Can you post them?

Comment 2

[Mark Côté [:mcote]]

Also note that Python 2.7.12 has some SSL/TLS-related bugs.  I strongly suggest upgrading to 2.7.13.

Comment 3

[David Walsh :davidwalsh]

Digging further I see:

```
rbweb> TASK: [mozreview-virtualenv | install dependency packages] ******************** 
rbweb> changed: [localhost] => (item=httpd-devel,libjpeg-turbo-devel,mysql-devel,nodejs,python-devel,openldap-devel,python27,tar,zlib-devel)
rbweb> TASK: [mozreview-virtualenv | install Node packages] ************************** 
rbweb> failed: [localhost] => {"cmd": "/usr/bin/npm install -g less uglify-js", "failed": true, "rc": 2}
rbweb> msg: [Errno 2] No such file or directory
rbweb> FATAL: all hosts have already failed -- aborting
```
Not sure if that means there's a JS problem with a file (why that would stop uglify installation I have no idea...) or if there's another issue.  Still looking.

Comment 4

[David Walsh :davidwalsh]

Full stack here: https://gist.github.com/darkwing/005d46af014b06debabfa7dac01eabcb

Comment 5

[Mark Côté [:mcote]]

I rebuilt my rbweb and am seeing this too.  This is probably what zalun is also seeing.

CI is also busted but seemingly for another reason.

Comment 6

[Gregory Szorc [:gps]]

Attachment: ansible/rbweb: install npm package (bug 1328353);

The Docker image build was complaining because /usr/bin/npm did not
exist. Either this has been broken for a while or the upstream
"node" package stopped including "npm" as a dependency. Whatever
the cause, installing the "npm" package makes this error go away.

Review commit: https://reviewboard.mozilla.org/r/102012/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/102012/

Comment 7

[David Walsh :davidwalsh]

Comment on attachment 8823488 [details]
ansible/rbweb: install npm package (bug 1328353);

https://reviewboard.mozilla.org/r/102012/#review102568

Works for me!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/9e54461ef1ed
ansible/rbweb: install npm package ; r=davidwalsh