1328367 - open_message_from_file() in test-folder-display-helpers.js (Mozmill) should check whether a file exists

Status: RESOLVED FIXED

(Thunderbird :: Testing Infrastructure, enhancement)

Description

[Jorg K (CEST = GMT+2)]

open_message_from_file() in test-folder-display-helpers.js (Mozmill) should check whether a file exists and display an appropriate message.

If called with a non-existent file, an unhelpful error is currently issued:
EXCEPTION: Timed out waiting for message display

Comment 2

[:aceman]

Attachment: patch

This should do it.
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=6bc6926d32bf53a2b2db1708649d1639d05e8f8d

Comment 3

[Jorg K (CEST = GMT+2)]

Comment on attachment 8839821 [details] [diff] [review]
patch

Review of attachment 8839821 [details] [diff] [review]:
-----------------------------------------------------------------

Nice, I asked for this, so thanks.

::: mail/test/mozmill/shared-modules/test-folder-display-helpers.js
@@ +666,5 @@
>  function open_message_from_file(file) {
>    mark_action("fdh", "open_message_from_file", ["file", file.nativePath]);
>  
> +  if (!file.isFile() || !file.isReadable())
> +    throw new Error("The requested message file " + file.leafName + " was not found.");

... was not found or is not accessible.

Comment 4

[:aceman]

Thanks, please do the change if possible when landing the next batch of patches.

Comment 5

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/comm-central/rev/b5d9d971165dce327ad943061fb9c0e0243e9ed0
Landed with requested adjustment.