Closed Bug 1328370 Opened 7 years ago Closed 7 years ago

remove GeckoSampler::mPrimaryThreadProfile

Categories

(Core :: Gecko Profiler, defect)

Product:
Core
Component:
Gecko Profiler
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla53
Tracking Flags:
Tracking Status
firefox53 --- fixed

People

(Reporter: froydnj, Assigned: froydnj)

Details

Attachments

(1 file)

remove GeckoSampler::mPrimaryThreadProfile
3.12 KB, patch
mstange
: review+
Details | Diff | Splinter Review 
The only interesting setter of this field is
GeckoSampler::GetPrimaryThreadProfile, which is unused.  Once that
function is removed, mPrimaryThreadProfile is set to null in
GeckoSampler's constructor and never changed or referenced.

        Attachment #8823397 -
        Flags: review?(mstange)

        Attachment #8823397 -
        Flags: review?(mstange) → review+

    
    

    
  
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/faffd8c889bd
remove GeckoSampler::mPrimaryThreadProfile; r=mstange

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/faffd8c889bd
Status: NEW → RESOLVED
Closed: 7 years ago

          status-firefox53:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53

          You need to log in
          before you can comment on or make changes to this bug.