1328398 - Add telemetry to measure how long the Service Worker takes to start up

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, defect, P3)

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

We track the information for this now, I think, in "LaunchServiceWorker" time fields.  All we need to do is add the probes.

HoPang, do you have any time available to do this?

Comment 2

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to Ben Kelly [:bkelly] from comment #1)
> We track the information for this now, I think, in "LaunchServiceWorker"
> time fields.  All we need to do is add the probes.
> 
> HoPang, do you have any time available to do this?

I am also CC Tom here and see if he has time to help (feel free to let me know if you don't, please).

Comment 3

[Ben Hsu [:HoPang]]

Hi Tom,

I am kind of occupied by alternative data stuff. It would be great if you can help, do you mind taking this?

Comment 4

[Tom Tung [:tt, :ttung]]

Steal this from Ho-Pang :P

Comment 5

[Tom Tung [:tt, :ttung]]

Attachment: Bug 1328398 - Add telemetry to measure service worker launch time. datareview=francois

Review commit: https://reviewboard.mozilla.org/r/169608/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/169608/

Comment 6

[Tom Tung [:tt, :ttung]]

Hi Ben,

This patch is to measure the launch time for a SW. Could you help me to review it? Thanks! 

I'll send it to data-review after getting r+ from you.

Comment 7

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8898583 [details]
Bug 1328398 - Add telemetry to measure service worker launch time.  datareview=francois

https://reviewboard.mozilla.org/r/169608/#review175312

::: dom/workers/ServiceWorkerPrivate.cpp:1512
(Diff revision 1)
>    WorkerRun(JSContext* aCx, WorkerPrivate* aWorkerPrivate) override
>    {
>      MOZ_ASSERT(aWorkerPrivate);
>  
>      if (mMarkLaunchServiceWorkerEnd) {
> -      mInterceptedChannel->SetLaunchServiceWorkerEnd(TimeStamp::Now());
> +      TimeStamp launchStartTime = TimeStamp();

nit: You can just write this as `TimeStamp launchStartTime;`.  No need for the assignment.

::: toolkit/components/telemetry/Histograms.json:11160
(Diff revision 1)
>      "alert_emails": ["[e-mail]"],
>      "bug_numbers": [1058133]
>    },
> +  "SERVICE_WORKER_LAUNCH_TIME": {
> +    "record_in_processes": ["main", "content"],
> +    "expires_in_version": "61",

I think we should make the case that this probe should not expire.  Large sites care a lot about SW performance and in particular the possible delay from starting the worker.  We need to monitor this for the foreseeable future.

Comment 8

[Tom Tung [:tt, :ttung]]

Comment on attachment 8898583 [details]
Bug 1328398 - Add telemetry to measure service worker launch time.  datareview=francois

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/169608/diff/1-2/

Comment 9

[Tom Tung [:tt, :ttung]]

(In reply to Tom Tung [:tt] from comment #8)
> Comment on attachment 8898583 [details]
> Bug 1328398 - Add telemetry to measure service worker launch time.
> 
> Review request updated; see interdiff:
> https://reviewboard.mozilla.org/r/169608/diff/1-2/

data-collection review

Comment 10

[François Marier [:francois]]

Comment on attachment 8898583 [details]
Bug 1328398 - Add telemetry to measure service worker launch time.  datareview=francois

https://reviewboard.mozilla.org/r/169608/#review176442

This is [Category 1](https://wiki.mozilla.org/Firefox/Data_Collection#Data_Collection_Categories) data.

datareview+

Comment 11

[Tom Tung [:tt, :ttung]]

Comment on attachment 8898583 [details]
Bug 1328398 - Add telemetry to measure service worker launch time.  datareview=francois

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/169608/diff/2-3/

Comment 12

[Tom Tung [:tt, :ttung]]

(In reply to Ben Kelly [:bkelly] from comment #7)
(In reply to François Marier [:francois] from comment #10)
Thanks for the review!

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cd6b4d4a1bdc
Add telemetry to measure service worker launch time. r=bkelly,francois datareview=francois

Comment 14

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/cd6b4d4a1bdc