Closed Bug 1328421 Opened 4 years ago Closed 4 years ago

Replace MessageId with ID in the IPDL parser

Categories

(Core :: IPC, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox54 --- fixed

People

(Reporter: mccr8, Assigned: mccr8)

Details

Attachments

(1 file)

Bill pointed out that this doesn't really do anything useful. The __delete__ case is completely redundant as far as I can tell. I don't think throwing an error if somebody names a message delete is very useful. We could probably also drop "delete" as a keyword. I think "delete" used to be used instead of "__delete__", and this error checking was added to ease the transition for people, but the change was made 6 or more years ago.
Assignee: nobody → continuation
Comment on attachment 8837233 [details]
Bug 1328421 - Replace MessageId with ID in the IPDL parser.

https://reviewboard.mozilla.org/r/112408/#review114336
Attachment #8837233 - Flags: review?(wmccloskey) → review+
Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9906e1364f04
Replace MessageId with ID in the IPDL parser. r=billm
https://hg.mozilla.org/mozilla-central/rev/9906e1364f04
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.