When no redundant encodings are specified for RED in offer, do not output "empty" fmtp line for RED payload type in answer

RESOLVED FIXED in Firefox 53

Status

()

Core
WebRTC: Signaling
P2
normal
Rank:
21
RESOLVED FIXED
10 months ago
9 months ago

People

(Reporter: mjf, Assigned: mjf)

Tracking

unspecified
mozilla53
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox53 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

10 months ago
When receiving an offer with RED with no redundant encodings indicated, we output
a=ftmp:102

We should not output the fmtp line when there are no redundant encodings.
(Assignee)

Updated

10 months ago
Rank: 21
Priority: -- → P2
(Assignee)

Updated

10 months ago
Assignee: nobody → mfroman
Comment hidden (mozreview-request)

Comment 2

10 months ago
mozreview-review
Comment on attachment 8824134 [details]
Bug 1328429 - don't output empty fmtp line when no redundant encodings are indicated for RED.

https://reviewboard.mozilla.org/r/102684/#review103130

::: media/webrtc/signaling/gtest/jsep_session_unittest.cpp:3127
(Diff revision 1)
>            (dtmf_params);
>  
>    ASSERT_EQ("0-15", parsed_dtmf_params.dtmfTones);
>  }
>  
> +TEST_F(JsepSessionTest, VerifyNoFmtpForRedReceiveOnly)

The test name implies a recv only situation, but the test itself appears to be doing sendrecv in both directions. Can you adjust the test name?
Attachment #8824134 - Flags: review?(drno) → review+
Comment hidden (mozreview-request)
(Assignee)

Updated

9 months ago
Keywords: checkin-needed

Comment 4

9 months ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/26e27966f5f0
don't output empty fmtp line when no redundant encodings are indicated for RED. r=drno
Keywords: checkin-needed

Comment 5

9 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/26e27966f5f0
Status: NEW → RESOLVED
Last Resolved: 9 months ago
status-firefox53: --- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.