1328459 - Give the clang-tidy jobs names so that their artifacts can be looked up in the index

Status: RESOLVED FIXED

(Taskcluster :: General, defect)

Description

[(no longer active)]

I'm using static-analysis as the name of the product.

Comment 1

[(no longer active)]

Attachment: Give the clang-tidy jobs names so that their artifacts can be looked up in the index; r=dustin

I'm using static-analysis as the name of the product.

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8823462 [details] [diff] [review]
Give the clang-tidy jobs names so that their artifacts can be looked up in the index; r=dustin

Review of attachment 8823462 [details] [diff] [review]:
-----------------------------------------------------------------

Passing this over to mike for his thoughts on the product name..

Comment 3

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8823462 [details] [diff] [review]
Give the clang-tidy jobs names so that their artifacts can be looked up in the index; r=dustin

Review of attachment 8823462 [details] [diff] [review]:
-----------------------------------------------------------------

::: taskcluster/ci/toolchain/linux.yml
@@ +26,5 @@
>  linux64-clang-tidy/opt:
>      description: "Clang-tidy build"
> +    index:
> +        product: static-analysis
> +        job-name: linux64-clang-tidy

Hm, actually, maybe I'm confused about what this does -- this job is building a toolchain thing called "clang-tidy", right?  It's not doing static analysis on the Gecko code, is it?

If it is doing some kind of static analysis of Gecko, it shouldn't be in the "toolchain" kind, as that kind is designed for building toolchains that are then used in builds.  It should be in the "static-analysis" kind.

Comment 4

[(no longer active)]

(In reply to Dustin J. Mitchell [:dustin] from comment #3)
> Comment on attachment 8823462 [details] [diff] [review]
> Give the clang-tidy jobs names so that their artifacts can be looked up in
> the index; r=dustin
> 
> Review of attachment 8823462 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: taskcluster/ci/toolchain/linux.yml
> @@ +26,5 @@
> >  linux64-clang-tidy/opt:
> >      description: "Clang-tidy build"
> > +    index:
> > +        product: static-analysis
> > +        job-name: linux64-clang-tidy
> 
> Hm, actually, maybe I'm confused about what this does -- this job is
> building a toolchain thing called "clang-tidy", right?  It's not doing
> static analysis on the Gecko code, is it?

No, but the connection is that it's going to be used to enable developers to run static analysis checks locally (bug 1328454).  The reason why I need to register them in the TaskCluster Index under a meaningful product name is to later be able to look up the latest binary we've built and download it to run locally.

> If it is doing some kind of static analysis of Gecko, it shouldn't be in the
> "toolchain" kind, as that kind is designed for building toolchains that are
> then used in builds.  It should be in the "static-analysis" kind.

It just builds the tool that will be used for the purposes of static analysis later, so I think toolchain is more appropriate.  But I can change it if you feel strongly.

Comment 5

[Dustin J. Mitchell [:dustin] (he/him)]

It sounds like it's in the right place, then.  So just looking for some info from Mike regarding the job names -- the alternative would be a route for this specific task (not under gecko.v2).

Comment 6

[Michael Shal [:mshal]]

Comment on attachment 8823462 [details] [diff] [review]
Give the clang-tidy jobs names so that their artifacts can be looked up in the index; r=dustin

Naming looks good to me. The new product sounds like a good spot for this.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b4faf5602cc7
Give the clang-tidy jobs names so that their artifacts can be looked up in the index; r=mshal

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b4faf5602cc7