Closed
Bug 1328469
Opened 7 years ago
Closed 7 years ago
Remove the logslice API now that the log viewer downloads the logs directly
Categories
(Tree Management :: Treeherder: API, defect, P3)
Tree Management
Treeherder: API
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: emorley, Assigned: emorley)
References
Details
Attachments
(1 file)
Now that the new log viewer (bug 1315808) has landed, the /logslice/ API and related functionality (eg file based caching config) can be removed. Once that bug is deployed to prod we'll want to check papertrail and/or New Relic to see if anyone else is using the API, to determine if we can just remove it or have to notify first. eg using: https://papertrailapp.com/systems/treeherder-prod/events?q=logslice https://rpm.newrelic.com/accounts/677903/applications/14179757/transactions?type=app#id=5b225765625472616e73616374696f6e2f46756e6374696f6e2f747265656865726465722e7765626170702e6170692e6c6f67736c6963653a4c6f67536c696365566965772e6c697374222c22225d https://insights.newrelic.com/accounts/677903/explorer/events?eventType=Transaction&filters=%255B%257B%2522key%2522%253A%2522name%2522%252C%2522value%2522%253A%2522WebTransaction%252FFunction%252Ftreeherder%252ewebapp%252eapi%252elogslice%253ALogSliceView%252elist%2522%257D%255D&duration=604800000&facet=appName
Comment 1•7 years ago
|
||
Assignee | ||
Comment 3•7 years ago
|
||
I couldn't find any /logslice/ mentions on GitHub via eg: https://github.com/search?utf8=%E2%9C%93&q=treeherder+logslice&type=Code&ref=searchresults https://github.com/search?l=Python&q=logslice&ref=searchresults&type=Code&utf8=%E2%9C%93
Assignee | ||
Comment 4•7 years ago
|
||
Comment on attachment 8823478 [details] [review] [treeherder] mozilla:rm-logslice-api > mozilla:master I'll check for usage prior to landing in a couple of days.
Attachment #8823478 -
Flags: review?(wlachance)
Comment 5•7 years ago
|
||
Comment on attachment 8823478 [details] [review] [treeherder] mozilla:rm-logslice-api > mozilla:master Very happy to see this go.
Attachment #8823478 -
Flags: review?(wlachance) → review+
Comment 6•7 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/422cd3390b7204d3b11e6c88754cbba37625c294 Bug 1328469 - Remove the now unused logslice API The new log viewer loads the logs directly in the client from wherever they are stored, so doesn't need Treeherder's API to proxy them. The logslice API was the only user of the Django filesystem cache, so that has also been removed.
Assignee | ||
Comment 7•7 years ago
|
||
Aside from a stray logviewer page that had been left open (judging by other accesses from that IP), there's no other usage of the API, no code hits on GitHub - so I've landed this.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 8•7 years ago
|
||
Zero hits on the prod API now.
You need to log in
before you can comment on or make changes to this bug.
Description
•