Closed
Bug 1328493
Opened 7 years ago
Closed 7 years ago
Injecting DXGI resources to ANGLE as gl texture.
Categories
(Core :: Graphics: WebRender, defect)
Tracking
()
RESOLVED
FIXED
mozilla54
People
(Reporter: mtseng, Assigned: mtseng)
References
Details
Attachments
(1 file, 2 obsolete files)
5.74 KB,
patch
|
jrmuizel
:
review+
|
Details | Diff | Splinter Review |
We need this for rendering DXGI textures in webrender
Assignee | ||
Comment 1•7 years ago
|
||
I have successful injected the DXGI textures which are created by content client into ANGLE. However, the DXGI textures generated by WebGL fail to render because the DXGI textures created by WebGL using the D3D11_RESOURCE_MISC_SHARED_KEYEDMUTEX flag but ANGLE didn't using key mutex before rendering. If I change the flag from D3D11_RESOURCE_MISC_SHARED_KEYEDMUTEX to D3D11_RESOURCE_MISC_SHARED then the result is good. I'll debug why ANGLE doesn't use key mutex before rendering.
Assignee | ||
Comment 2•7 years ago
|
||
Assignee | ||
Comment 3•7 years ago
|
||
After tweaking some ANGLE source code. I can get the result for WebGL. So my next tasks are: 1. Expose CreatePBufferFromClientBuffer in GLLibraryEGL. 2. Modify ANGLE so that ANGLE can handle the DXGI texture with keyed mutex. 3. Hook all things in our TextureClient/Host codes.
Assignee | ||
Comment 4•7 years ago
|
||
MozReview-Commit-ID: JhFdwkCvIsO
Attachment #8833227 -
Flags: review?(jmuizelaar)
Assignee | ||
Comment 5•7 years ago
|
||
We need upstream this to ANGLE eventually. MozReview-Commit-ID: 65PEv0kbyiu
Attachment #8833228 -
Flags: review?(jmuizelaar)
Assignee | ||
Comment 6•7 years ago
|
||
Comment on attachment 8833228 [details] [diff] [review] Let ANGLE handle DXGI texture with keyed mutex properly. We don't need this anymore since we can AcquireSync and ReleaaeSync by ourselves.
Attachment #8833228 -
Flags: review?(jmuizelaar)
Assignee | ||
Updated•7 years ago
|
Attachment #8833228 -
Attachment is obsolete: true
Assignee | ||
Updated•7 years ago
|
Attachment #8828840 -
Attachment is obsolete: true
Assignee | ||
Comment 7•7 years ago
|
||
Jeff, review ping for the patch. Thanks very much.
Flags: needinfo?(jmuizelaar)
Updated•7 years ago
|
Attachment #8833227 -
Flags: review?(jmuizelaar) → review+
Assignee | ||
Comment 9•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=20a3d3b0cae57a74aeb0e8902b6a832acecfe91a
Comment 10•7 years ago
|
||
Pushed by mtseng@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/b0cbe5152086 Expose CreatePBufferFromClientBuffer and EGL_ANGLE_d3d_share_handle_client_buffer. r=jrmuizel
Comment 11•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/b0cbe5152086
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in
before you can comment on or make changes to this bug.
Description
•