Closed Bug 1328508 Opened 3 years ago Closed 3 years ago

Increase the print watchdog timer for debug builds, and add some warnings to make watchdog timeouts visible

Categories

(Core :: Printing: Output, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox52 --- fixed
firefox53 --- fixed

People

(Reporter: jwatt, Assigned: jwatt)

References

()

Details

Attachments

(1 file)

I just wasted a whole bunch of time trying to repro/debug bug 1324908 on aurora where the behavior is non-determinitic. The sometimes failing behavior on aurora turns out to be unrelated to the bug on beta, and is actually due to us failing a timeout in some scenarios.

One example is printing:

  http://www.ivis.org/proceedings/voorjaarsdagen/2016/3.pdf

This tends to fail if the entire document hasn't been pre-rendered before requesting a print (either by scrolling to the end, or by a previous, perhaps failed, print).
Attached patch patchSplinter Review
Attachment #8823514 - Flags: review?(bobowencode)
Attachment #8823514 - Flags: review?(bobowencode) → review+
Pushed by jwatt@jwatt.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/56f12a46fbca
Increase the print watchdog timer for debug builds, and add some warnings to make watchdog timeouts visible. r=bobowen
https://hg.mozilla.org/mozilla-central/rev/56f12a46fbca
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Comment on attachment 8823514 [details] [diff] [review]
patch

Approval Request Comment
[Feature/Bug causing the regression]: n/a
[User impact if declined]: none - this is for debug builds for gecko devs. lots of people are currently working on printing and debugging on branches. This potentially helps them avoid wasting lots of time with bogus failures.
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no
[Why is the change risky/not risky?]: it just adds some warnings and increases a timeout for slow debug builds
[String changes made/needed]: none
Attachment #8823514 - Flags: approval-mozilla-aurora?
Comment on attachment 8823514 [details] [diff] [review]
patch

increase timeout for printing in debug builds, aurora52+
Attachment #8823514 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.