Open Bug 1328522 Opened 3 years ago Updated 19 days ago

Intermittent layout/style/test/test_restyles_in_smil_animation.html | should restyle in most frames, | should restyle again

Categories

(Core :: Layout, defect)

defect
Not set

Tracking

()

ASSIGNED

People

(Reporter: intermittent-bug-filer, Assigned: birtles)

References

Details

(Keywords: intermittent-failure, leave-open, Whiteboard: [stockwell disabled])

Attachments

(1 file)

This become very frequent since yesterday?
CCing Brian too since I suspect the high frequency started from dropping eRestyle_StyleAttribute [1].  I have no idea why dropping the restyle hint breaks this test. Unfortunately we have no idea how many restyles we got in the failure cases for now.

[1] https://hg.mozilla.org/integration/mozilla-inbound/rev/0c8900bc3ec0d42c27871127558078063213f7f0
We don't know what the value of displayMarkers.length is so it's hard to know how this has changed. We should probably just disable this test for Android. It doesn't seem like it's likely to fail in a meaningful way on Android only.
It's nearly the weekend here, so I'm just going to suggest we disable this. I'll also push a patch to try with some more informative logging so next week we can think about what might be going wrong.
Comment on attachment 8869338 [details]
Bug 1328522 - Disable test_restyles_in_smil_animation.html;

https://reviewboard.mozilla.org/r/140972/#review144450

Quick hand!
Attachment #8869338 - Flags: review?(hikezoe) → review+
Assignee: nobody → bbirtles
Status: NEW → ASSIGNED
Thanks!

Here is a try run without the test disabled and just the extra logging (so we can retrigger and see how this fails):
https://treeherder.mozilla.org/#/jobs?repo=try&revision=05ff4d966c878fc16d7a6a0de319279d1eff55fe
I should have used an artifact build for that try run... oh well.
Pushed by bbirtles@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e3f094340972
Disable test_restyles_in_smil_animation.html; r=hiro
And that commit message should have mentioned Android :(
It's time to go home.
Keywords: leave-open
Whiteboard: [stockwell disabled]
See Also: → 1443320
You need to log in before you can comment on or make changes to this bug.