1328539 - glCopyTexSubImage2D broken in Beta/Nightly

Status: VERIFIED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Biru [:poiru]]

Open https://www.figma.com/preload-editor on Firefox release. The canvas should be empty and a solid grey color.

Now repeat this in Firefox Nightly and note that the canvas is not empty and has checkerboards.

I'm afraid I don't have a reduced testcase at the moment.

This seems to be related to the changes in bug 1305832. (I tested on macOS, FWIW.)

Comment 1

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1328539 - writeX/Y should be relative to x/yOffset. -

Review commit: https://reviewboard.mozilla.org/r/102364/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/102364/

Comment 2

[Kelsey Gilbert [:jgilbert]]

[Tracking Requested - why for this release]:
WebGL 1 regression known to break some content.

Comment 3

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1328539 - Add test.

Review commit: https://reviewboard.mozilla.org/r/102368/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/102368/

Comment 4

[Daosheng Mu[:daoshengmu]]

Comment on attachment 8823902 [details]
Bug 1328539 - writeX/Y should be relative to x/yOffset. -

https://reviewboard.mozilla.org/r/102364/#review102756

LGTM

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/dc713109ebb1
writeX/Y should be relative to x/yOffset. - r=daoshengmu

Comment 6

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8823902 [details]
Bug 1328539 - writeX/Y should be relative to x/yOffset. -

Approval Request Comment
[Feature/Bug causing the regression]: WebGL 1 regression
[User impact if declined]:
[Is this code covered by automated tests?]: Test included.
[Has the fix been verified in Nightly?]: Yes.
[Needs manual test from QE? If yes, steps to reproduce]: 
[List of other uplifts needed for the feature/fix]:
[Is the change risky?]: No.
[Why is the change risky/not risky?]: Isolated and simple to understand.
[String changes made/needed]: none

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/dc713109ebb1

Comment 8

[Julien Cristau [:jcristau]]

new webgl1 regression, tracking for 51

Comment 9

[Julien Cristau [:jcristau]]

Comment on attachment 8823902 [details]
Bug 1328539 - writeX/Y should be relative to x/yOffset. -

fix webgl1 regression in aurora52 and beta51, should be in 51.0b13

Comment 10

[Kelsey Gilbert [:jgilbert]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/04544accd96a
https://hg.mozilla.org/releases/mozilla-beta/rev/c47060095bd6

Comment 11

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

I reproduced this issue using 53.0a1, build ID: 20170104030214, on Windows 10 x64.
I can confirm this issue is fixed, I verified using Fx 51.0b13, build ID: 20170109165508 and Fx 52.0a2, build ID: 20170112004017 and Fx53.0a1, build ID: 20170112030301, on Windows 10 x64, Mac OS X 10.10.5 and Ubuntu 14.04 LTS.

Cheers!