1328541 - Remove the call to DispatchDecodeTasksIfNeeded() from MDSM::MaybeStartPlayback()

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Description

[JW Wang [:jwwang] [:jw_wang]]

http://searchfox.org/mozilla-central/rev/22be34bcc4d5c56b62482a537bba77a6cdce117b/dom/media/MediaDecoderStateMachine.cpp#2763

MaybeStartPlayback() is called by
1. CompletedState::Step() where no more decoding is needed.
2. DecodingState::Step() where DecodingState is in charge of decoding tasks to ensure smooth playback.

So we should remove the call to DispatchDecodeTasksIfNeeded() from MaybeStartPlayback().

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1328541 - Remove the call to DispatchDecodeTasksIfNeeded() from MDSM::MaybeStartPlayback().

Review commit: https://reviewboard.mozilla.org/r/102090/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/102090/

Comment 2

[Kilik Kuo [:kikuo] (inactive)]

Comment on attachment 8823557 [details]
Bug 1328541 - Remove the call to DispatchDecodeTasksIfNeeded() from MDSM::MaybeStartPlayback().

https://reviewboard.mozilla.org/r/102090/#review102786

LGTM

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9c76dbbb4bb5
Remove the call to DispatchDecodeTasksIfNeeded() from MDSM::MaybeStartPlayback(). r=kikuo

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9c76dbbb4bb5