1328547 - Move MDSM::Dispatch{Audio,Video}DecodeTaskIfNeeded into DecodingState

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Description

[JW Wang [:jwwang] [:jw_wang]]

For DecodingState is the only caller.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1328547. part 1 - Move MDSM::Dispatch{Audio,Video}DecodeTaskIfNeeded into DecodingState.

Review commit: https://reviewboard.mozilla.org/r/102376/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/102376/

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1328547. part 2 - remove checks for IsShutdown() which is false in DecodingState.

Review commit: https://reviewboard.mozilla.org/r/102378/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/102378/

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1328547. part 3 - inline NeedToDecode{Audio,Video} and remove some checks.

1. |mState != DECODER_STATE_SEEKING| is true in DecodingState.
2. mSentFirstFrameLoadedEvent is true in DecodingState.
3. mMinimizePreroll is false because pop events fire only after MDSM starts playing.

Review commit: https://reviewboard.mozilla.org/r/102380/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/102380/

Comment 4

[Tzuhao Kuo [:kaku]]

Comment on attachment 8823913 [details]
Bug 1328547. part 1 - Move MDSM::Dispatch{Audio,Video}DecodeTaskIfNeeded into DecodingState.

https://reviewboard.mozilla.org/r/102376/#review102818

Comment 5

[Tzuhao Kuo [:kaku]]

Comment on attachment 8823914 [details]
Bug 1328547. part 2 - remove checks for IsShutdown() which is false in DecodingState.

https://reviewboard.mozilla.org/r/102378/#review102820

Comment 6

[Tzuhao Kuo [:kaku]]

Comment on attachment 8823915 [details]
Bug 1328547. part 3 - inline NeedToDecode{Audio,Video} and remove some checks.

https://reviewboard.mozilla.org/r/102380/#review102822

Comment 7

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0c8699ee3348
part 1 - Move MDSM::Dispatch{Audio,Video}DecodeTaskIfNeeded into DecodingState. r=kaku
https://hg.mozilla.org/integration/autoland/rev/90ec1757f7c1
part 2 - remove checks for IsShutdown() which is false in DecodingState. r=kaku
https://hg.mozilla.org/integration/autoland/rev/ebe4694e8c33
part 3 - inline NeedToDecode{Audio,Video} and remove some checks. r=kaku

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/0c8699ee3348
https://hg.mozilla.org/mozilla-central/rev/90ec1757f7c1
https://hg.mozilla.org/mozilla-central/rev/ebe4694e8c33