1328654 - Clean up left-over processes in MarionetteHarness

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

While fixing Bug 1328411, I noticed that the Marionette runner can leave processes running if it hits an exception before tests start (i.e. during harness setup).

Comment 1

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Attachment: Bug 1328654 - Clean up after Marionette runner in MarionetteHarness;

This fixes the case where the call to runner.run_tests() raises
an exception before any tests start, thus leaving a
browser instance running.

Review commit: https://reviewboard.mozilla.org/r/102270/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/102270/

Comment 2

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=04368e4a089b693ef998044e48c92f6ceb9e6731

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 8823759 [details]
Bug 1328654 - Clean up after Marionette runner in MarionetteHarness;

https://reviewboard.mozilla.org/r/102270/#review102688

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ad6a2815361f
Clean up after Marionette runner in MarionetteHarness; r=whimboo

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ad6a2815361f