Closed Bug 1328679 Opened 3 years ago Closed 3 years ago
Uplift critical bug fixes
There are two serious debugger bugs, which we would like to uplift fixes for: Issues: * source map issue which selects the previous line (can't set a breakpoint) #1349 * the memory leak issue with the source tree (causes crashes w/ live reload) #1369 Fixes: * https://github.com/devtools-html/debugger.html/pull/1349 * https://github.com/devtools-html/debugger.html/pull/1369
Comment on attachment 8823794 [details] [diff] [review] uplift.patch Review of attachment 8823794 [details] [diff] [review]: ----------------------------------------------------------------- It all looks reasonable to me, and it was good enough for devtools.html... However I wonder about testing. It seems like there should be unit tests for failures like this; and furthermore the uplift form asks about that.
Attachment #8823794 - Flags: review?(ttromey) → review+
Thanks, I'll add the tests separately to avoid blocking on a new try run.
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/872fb8c4f914 Uplift a couple bugs. r=ttromey
Comment on attachment 8823794 [details] [diff] [review] uplift.patch [Feature/Bug causing the regression]: 1316413 [User impact if declined]: This fixes two issues: 1) firefox crashes when debugging sites with a lot of sources 2) adding a breakpoint on a source mapped file is difficult [Is this code covered by automated tests?]: Yes [Has the fix been verified in Nightly?]: Yes [Needs manual test from QE? If yes, steps to reproduce]: no [List of other uplifts needed for the feature/fix]: [Is the change risky?]: no [Why is the change risky/not risky?]: the fix has been on nightly for a week. It is also contained to the debugger. [String changes made/needed]:
Attachment #8823794 - Flags: approval-mozilla-aurora?
Comment on attachment 8823794 [details] [diff] [review] uplift.patch devtools debugger fixes for aurora52
Attachment #8823794 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.