1328684 - Convert SharedPreferencesHelper events to bundle events

Status: RESOLVED FIXED

(GeckoView :: General, defect)

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Convert SharedPreferencesHelper events to bundle events (v1)

Convert events used in SharedPreferencesHelper to
GeckoBundle/BundleEventListener events. Gecko thread events are used
because the listeners are expected to be synchronous, especially for the
SharedPreferences:Get event, which also requires a synchronous callback.

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8823790 [details] [diff] [review]
Convert SharedPreferencesHelper events to bundle events (v1)

Review of attachment 8823790 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/java/org/mozilla/gecko/SharedPreferencesHelper.java
@@ +147,2 @@
>          }
> +        editor.apply();

Woops, nice catch - .. to apply the changes only once.

@@ +211,5 @@
> +            try {
> +                msg.putBoolean("value", sharedPreferences.getBoolean(key, false));
> +                return;
> +            } catch (final ClassCastException e) {
> +            }

Not nice, but it seems like it's our only option.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4d1775e57bcc
Convert SharedPreferencesHelper events to bundle events; r=sebastian

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4d1775e57bcc