Closed Bug 1328696 Opened 3 years ago Closed 3 years ago

Remove usage of enforce_gecko_prefs() from test_modal_dialogs.py

Categories

(Testing :: Marionette, defect)

Version 3
defect
Not set

Tracking

(firefox52 fixed, firefox53 fixed)

RESOLVED FIXED
mozilla53
Tracking Status
firefox52 --- fixed
firefox53 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

References

Details

Attachments

(1 file)

Using enforce_gecko_prefs() for the unit test test_modal_dialogs.py should not be necessary because flipping this pref doesn't need a restart.

I tried to do it as part of bug 1326047 but as it looks like there is some more work to do here because the test doesn't clean up correctly. A modal dialog is left-open at the end, and causes various test failures in follow-up tests.
Assignee: nobody → hskupin
Blocks: 1297394
Status: NEW → ASSIGNED
Attachment #8824930 - Flags: review?(mjzffr)
Comment on attachment 8824930 [details]
Bug 1328696 - Remove usage of enforce_gecko_prefs() from test_modal_dialogs.py.

https://reviewboard.mozilla.org/r/103274/#review103862
Attachment #8824930 - Flags: review?(mjzffr) → review+
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/63cb5a65ac28
Remove usage of enforce_gecko_prefs() from test_modal_dialogs.py. r=maja_zf
https://hg.mozilla.org/mozilla-central/rev/63cb5a65ac28
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Please uplift this test-only patch to aurora. Thanks.
Whiteboard: [checkin-needed-aurora]
You need to log in before you can comment on or make changes to this bug.