bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

Move buglink filter before firstline filter

RESOLVED FIXED

Status

Developer Services
Mercurial: hg.mozilla.org
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: gps, Assigned: gps)

Tracking

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(3 attachments)

(Assignee)

Description

2 years ago
In bug 1325782, we expanded the "buglink" template filter to hyperlink to GitHub when appropriate.

Within seconds of me showing the deployed shiny hotness to Manishearth, he noticed it wasn't hyperlinking correctly in the short messages.

The reason for this is that the hyperlinking filter is running on only the first line of the string. So, it doesn't see the annotation telling it to link to GitHub.

We can fix this by changing the order of the filters so buglink runs before firstline.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 4

2 years ago
mozreview-review
Comment on attachment 8823832 [details]
hgmo: test for mozlink after firstline filter (bug 1328717);

https://reviewboard.mozilla.org/r/102318/#review102724

::: hgext/hgmo/tests/test-mozlink.t:63
(Diff revision 1)
>    Source-Repo: <a href="https://github.com/mozilla/foo">https://github.com/mozilla/foo</a>
> +
> +  $ cd ..
> +
> +Occurrences of the filter must occur *before* firstline otherwise it doesn't have
> +sufficient context to link appropriately.

A more detailed description of what and why we're testing here would be helpful. Even with the full context of this review, I was pretty confused about what was going on here.
Attachment #8823832 - Flags: review?(wlachance) → review+

Comment 5

2 years ago
mozreview-review
Comment on attachment 8823831 [details]
hgmo: rename "buglink" to "mozlink" (bug 1328717);

https://reviewboard.mozilla.org/r/102316/#review102726
Attachment #8823831 - Flags: review?(wlachance) → review+

Comment 6

2 years ago
mozreview-review
Comment on attachment 8823833 [details]
hgtemplates: move mozlink filter before firstline (bug 1328717);

https://reviewboard.mozilla.org/r/102320/#review102730
Attachment #8823833 - Flags: review?(wlachance) → review+
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 9

2 years ago
Pushed by gszorc@mozilla.com:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/34115287512c
hgmo: rename "buglink" to "mozlink" ; r=wlach
https://hg.mozilla.org/hgcustom/version-control-tools/rev/327e7ca92fe7
hgmo: test for mozlink after firstline filter ; r=wlach
https://hg.mozilla.org/hgcustom/version-control-tools/rev/1dcc7141886c
hgtemplates: move mozlink filter before firstline ; r=wlach
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.