Closed Bug 1328758 Opened 7 years ago Closed 7 years ago

Error when missing host permission is hard to understand

Categories

(WebExtensions :: General, defect, P2)

Product:
WebExtensions
Component:
General
Type:
defect

Tracking

(firefox55 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla55
Tracking Flags:
Tracking Status
firefox55 --- fixed

People

(Reporter: billm, Assigned: zombie)

Details

(Whiteboard: permission, triaged)

Attachments

(1 file)

Bug 1328758 - Better error messages for tabs.executeScript
59 bytes, text/x-review-board-request
kmag
: review+
Details 
If I use browser.tabs.executeScript without the appropriate permission, I just get this in the error console:
  Error: No window matching {"matchesHost":[]}

Would be better to give a message about not having the right permission.
Er, I guess I needed a host permission.
Summary: Error when missing "tabs" permission is hard to understand → Error when missing host permission is hard to understand
Flags: needinfo?(kmaglione+bmo)
Priority: -- → P2
Whiteboard: permission, triaged
Assignee: nobody → tomica
Status: NEW → ASSIGNED
Flags: needinfo?(kmaglione+bmo)
Attachment #8853705 - Flags: review?(kmaglione+bmo)
Comment on attachment 8853705 [details]
Bug 1328758 - Better error messages for tabs.executeScript

https://reviewboard.mozilla.org/r/125782/#review130036
Attachment #8853705 - Flags: review?(kmaglione+bmo) → review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/bd875ac1b420
Better error messages for tabs.executeScript r=kmag
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/bd875ac1b420
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: