Enable some eslint rules that we are already passing

RESOLVED FIXED in Firefox 53

Status

()

Toolkit
General
RESOLVED FIXED
6 months ago
6 months ago

People

(Reporter: jaws, Assigned: jaws)

Tracking

unspecified
mozilla53
Points:
---

Firefox Tracking Flags

(firefox53 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

I've done a pass-through of our code and we have 0 errors for the following eslint rules:

no-extra-label = 0
no-iterator = 0
no-regex-spaces = 0
no-self-assign = 0
no-unsafe-negation = 0
no-unused-labels = 0

These can be enabled to prevent any future errors from occurring.
Comment hidden (mozreview-request)

Comment 2

6 months ago
mozreview-review
Comment on attachment 8823940 [details]
Bug 1328795 - Enable some eslint rules that we are already passing.

https://reviewboard.mozilla.org/r/102414/#review102978
Attachment #8823940 - Flags: review?(dtownsend) → review+

Comment 3

6 months ago
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a914b8b3f301
Enable some eslint rules that we are already passing. r=mossop

Comment 4

6 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a914b8b3f301
Status: ASSIGNED → RESOLVED
Last Resolved: 6 months ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.