Last Comment Bug 1328795 - Enable some eslint rules that we are already passing
: Enable some eslint rules that we are already passing
Status: RESOLVED FIXED
:
Product: Toolkit
Classification: Components
Component: General (show other bugs)
: unspecified
: Unspecified Unspecified
-- normal (vote)
: mozilla53
Assigned To: Jared Wein [:jaws] (please needinfo? me)
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2017-01-04 20:57 PST by Jared Wein [:jaws] (please needinfo? me)
Modified: 2017-01-05 17:29 PST (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---
fixed

MozReview Requests
Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:
Show discarded requests

Attachments
Bug 1328795 - Enable some eslint rules that we are already passing. (59 bytes, text/x-review-board-request)
2017-01-04 20:59 PST, Jared Wein [:jaws] (please needinfo? me)
dtownsend: review+
Details | Review

Description User image Jared Wein [:jaws] (please needinfo? me) 2017-01-04 20:57:00 PST
I've done a pass-through of our code and we have 0 errors for the following eslint rules:

no-extra-label = 0
no-iterator = 0
no-regex-spaces = 0
no-self-assign = 0
no-unsafe-negation = 0
no-unused-labels = 0

These can be enabled to prevent any future errors from occurring.
Comment 1 User image Jared Wein [:jaws] (please needinfo? me) 2017-01-04 20:59:58 PST Comment hidden (mozreview-request)
Comment 2 User image Dave Townsend [:mossop] 2017-01-05 08:28:04 PST
Comment on attachment 8823940 [details]
Bug 1328795 - Enable some eslint rules that we are already passing.

https://reviewboard.mozilla.org/r/102414/#review102978
Comment 3 User image Pulsebot 2017-01-05 08:57:38 PST
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a914b8b3f301
Enable some eslint rules that we are already passing. r=mossop
Comment 4 User image Wes Kocher (:KWierso) 2017-01-05 17:29:45 PST
https://hg.mozilla.org/mozilla-central/rev/a914b8b3f301

Note You need to log in before you can comment on or make changes to this bug.