Last Comment Bug 1328796 - Enable the no-debugger rule for eslint
: Enable the no-debugger rule for eslint
Status: RESOLVED FIXED
:
Product: Toolkit
Classification: Components
Component: General (show other bugs)
: unspecified
: Unspecified Unspecified
-- normal (vote)
: mozilla53
Assigned To: Jared Wein [:jaws] (please needinfo? me)
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2017-01-04 21:03 PST by Jared Wein [:jaws] (please needinfo? me)
Modified: 2017-01-05 17:29 PST (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---
fixed

MozReview Requests
Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:
Show discarded requests

Attachments
Bug 1328796 - Enable the no-debugger rule for eslint and remove the one instance of 'debugger;'. (59 bytes, text/x-review-board-request)
2017-01-04 21:06 PST, Jared Wein [:jaws] (please needinfo? me)
aswan: review+
Details | Review

Description User image Jared Wein [:jaws] (please needinfo? me) 2017-01-04 21:03:57 PST
There is only one error reported with this rule enabled and it appears to be flotsam from when the patch was being authored.

c:\fx\toolkit\mozapps\extensions\test\browser\browser_bug581076.js
  88:5  error  Unexpected 'debugger' statement.  no-debugger (eslint)
Comment 1 User image Jared Wein [:jaws] (please needinfo? me) 2017-01-04 21:06:51 PST Comment hidden (mozreview-request)
Comment 2 User image Andrew Swan [:aswan] 2017-01-04 22:11:05 PST
Comment on attachment 8823942 [details]
Bug 1328796 - Enable the no-debugger rule for eslint and remove the one instance of 'debugger;'.

https://reviewboard.mozilla.org/r/102418/#review102784

whoops, how did that ever get past review...?
Comment 3 User image Jared Wein [:jaws] (please needinfo? me) 2017-01-05 08:58:09 PST
(In reply to Andrew Swan [:aswan] from comment #2)
> whoops, how did that ever get past review...?

Well it won't in the future :)
Comment 4 User image Pulsebot 2017-01-05 08:58:25 PST
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c8c8c4f545f7
Enable the no-debugger rule for eslint and remove the one instance of 'debugger;'. r=aswan
Comment 5 User image Wes Kocher (:KWierso) 2017-01-05 17:29:47 PST
https://hg.mozilla.org/mozilla-central/rev/c8c8c4f545f7

Note You need to log in before you can comment on or make changes to this bug.