Closed Bug 1328822 Opened 6 years ago Closed 6 years ago

cache getSelectedRequest with reselect

Categories

(DevTools :: Netmonitor, defect, P1)

Product:
DevTools
Component:
Netmonitor
Type:
defect

Tracking

(firefox53 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 53
Iteration:
53.4 - Jan 9
Tracking Flags:
Tracking Status
firefox53 --- fixed

People

(Reporter: gasolin, Assigned: gasolin)

References

(Blocks 1 open bug)

Details

(Whiteboard: [netmonitor])

Attachments

(1 file)

Bug 1328822 - cache getSelectedRequest with reselect;
59 bytes, text/x-review-board-request
jsnajdr
: review+
Details 
== branch from bug 1317649 ==

selectors/request::getSelectedRequest is now queried each time when state updated

we could cache getSelectedRequest with reselect to avoid unnecessary change
Comment on attachment 8823983 [details]
Bug 1328822 - cache getSelectedRequest with reselect;

https://reviewboard.mozilla.org/r/102468/#review102828

Looks good, r+ if try is green.
Attachment #8823983 - Flags: review?(jsnajdr) → review+
Iteration: --- → 53.4 - Jan 9
Flags: qe-verify?
Priority: -- → P1
tree green with 1 unrelated webconsole test fail, thanks!
Keywords: checkin-needed
Pushed by jsnajdr@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/50ab4998bee7
cache getSelectedRequest with reselect; r=jsnajdr
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/50ab4998bee7
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
Flags: qe-verify? → qe-verify-
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.