cache getSelectedRequest with reselect

RESOLVED FIXED in Firefox 53

Status

P1
normal
RESOLVED FIXED
2 years ago
4 months ago

People

(Reporter: gasolin, Assigned: gasolin)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 53
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox53 fixed)

Details

(Whiteboard: [netmonitor])

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
== branch from bug 1317649 ==

selectors/request::getSelectedRequest is now queried each time when state updated

we could cache getSelectedRequest with reselect to avoid unnecessary change
Comment hidden (mozreview-request)

Comment 2

2 years ago
mozreview-review
Comment on attachment 8823983 [details]
Bug 1328822 - cache getSelectedRequest with reselect;

https://reviewboard.mozilla.org/r/102468/#review102828

Looks good, r+ if try is green.
Attachment #8823983 - Flags: review?(jsnajdr) → review+

Updated

2 years ago
Iteration: --- → 53.4 - Jan 9
Flags: qe-verify?
Priority: -- → P1
(Assignee)

Comment 3

2 years ago
tree green with 1 unrelated webconsole test fail, thanks!
Keywords: checkin-needed

Comment 4

2 years ago
Pushed by jsnajdr@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/50ab4998bee7
cache getSelectedRequest with reselect; r=jsnajdr
Keywords: checkin-needed

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/50ab4998bee7
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53

Updated

2 years ago
Flags: qe-verify? → qe-verify-

Updated

4 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.