1328853 - Console message gets logged every time, not only after overrides

Status: VERIFIED FIXED

(Web Compatibility :: Interventions, defect)

Description

[Dennis Schubert [:denschub]]

The message "The user agent has been overridden for compatibility reasons." shows up every time, not only if an user agent override was in place.

Comment 1

[Dennis Schubert [:denschub]]

Attachment: Pull request to fix this issue, Version 1

Using `getUAForURI` is not the best idea, since it will return an UA string regardless if we need to override it or not. Therefore, I've implemented `hasUAForURIInCache` do actually check if we need to override the current URI or not.

Comment 2

[Eric Tsai (no more review request accepted)]

Comment on attachment 8824042 [details] [review]
Pull request to fix this issue, Version 1

Looks good for me to use hasUAForURIInCache for check override only

Comment 3

[Dennis Schubert [:denschub]]

Thanks, merged.

Comment 4

[ovidiu boca[:Ovidiu]]

Tested on Mac OS X 10.10, 10.12, Ubuntu 16.04 x64 and Windows 10 x64 with Firefox Nighlty 53.0a1(2016-01-05) ussing the .xpi with the fix received from Dennis and I can confirm the fix.