1328907 - Land late string change for about:tabcrashed

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

In bug 1309316, we noticed that one of the strings that we landed was incorrect, and is potentially confusing. See bug 1309316 comment 42 and onwards, in particular.

In bug 1309316 comment 45, flod suggested we attempt to land the corrected string and hope a late string change can be properly translated. This bug is to track that work.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1328907 - Correct a string in about:tabcrashed.

Review commit: https://reviewboard.mozilla.org/r/102646/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/102646/

Comment 2

[Francesco Lodolo [:flod]]

Comment on attachment 8824097 [details]
Bug 1328907 - Correct a string in about:tabcrashed.

https://reviewboard.mozilla.org/r/102646/#review102976

Looks good, thanks.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/58396ef7d409
Correct a string in about:tabcrashed. r=flod

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8824097 [details]
Bug 1328907 - Correct a string in about:tabcrashed.

Approval Request Comment
[Feature/Bug causing the regression]:

Bug 1309316

[User impact if declined]:

A string will appear in about:tabcrashed that isn't as clear as it should be.

[Is this code covered by automated tests?]:

about:tabcrashed definitely is.

[Has the fix been verified in Nightly?]:

Not yet, but it just autolanded.

[Needs manual test from QE? If yes, steps to reproduce]: 

No.

[List of other uplifts needed for the feature/fix]:

None.

[Is the change risky?]:

No, except for localizers, since this is a late string landing - but flod is aware.

[Why is the change risky/not risky?]:

See above.

[String changes made/needed]:

This is a string change. flod is aware.

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/58396ef7d409

Comment 6

[Julien Cristau [:jcristau]]

Comment on attachment 8824097 [details]
Bug 1328907 - Correct a string in about:tabcrashed.

fix a string in about:tabcrashed, l10n-acked, aurora52+

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/a63790bb6489

Comment 8

[Mike Conley (:mconley) (:⚙️)]

Thanks KWiesro / jcristau / aryx. Anything else I need to do here, flod?

Comment 9

[Francesco Lodolo [:flod]]

No, everything landed, dashboard is showing the missing string, message sent.
https://groups.google.com/d/msg/mozilla.dev.l10n/zGU5cb_8wzo/26ka-SdVEwAJ