132898 - can't get out of list mode when there is blank line underneath list item

Status: VERIFIED WONTFIX

(SeaMonkey :: Composer, defect)

Description

[sujay]

using 3/22 build of netscape

1) launch netscape
2) launch composer
3) enter a bullet list item
4) enter some text
5) hit return
6) enter more text
7) shift-return
8) now click in the 2nd bullet list item
9) click on bullet list icon on toolbar to get out of bullet mode(users may
wanna take that text out of list mode)

Actual results= end up with a second level list item below the list like this:

* text in bullet 1
* 
	O text in bullet 2

Expected results = text in bullet 2 should be taken out of that 2nd bullet like
this:

 * text in bullet 1
text in bullet 2

Also wanted to mention user got into this state(where there are shift-returns)
because they brought in a document from 4.x

Comment 1

[sujay]

workaround = 

user should click on the bullet icon for the list item
they wants to unlist.  This will select the entire list item (including any
blank lines).  Then the list code will know that she means to unlist that list
item. 

marking nsbeta1/EDITROBASE because uses may bring in legacy documents which can
be chocked full of shift-returns(blank lines below bullet items)

Comment 2

[lchiang]

Yes, that is how I ran into this problem.  I am editing a document (simple
agenda with bullet items in it) and I had wanted to promote a line of text
outside of the bulleted list.  I guess that 4.x documents show some
shift-returns in it (where I didn't actually even do a shift-return!).

Comment 3

[Joe Francis]

This is another lose-lose bug.  It can't be fixed unless you make the "make list" 
ui always mean remove list whenever you are anywhere in a list.  So, for 
instance, if you have a document that is pretty rich and is divided between 4 
list items, and you select a few lines in one of the list items and try to make a 
list there, you would get that whole master list items outdented.  

I think we should probably leave this alone.  We did do this kind of thing for 
indent (indent will indent the whole list item even if you have a bunch of 
different blocks in it and you only select one of them), and there is an open bug 
to also extend this work to outdent.  

If the open bug were fix then outdent would do what you were trying to do here, 
and makelist could still be used if you really wanted to create a new "list 
inside a list".

Comment 4

[lchiang]

What is the open bug?

From a user's perspective, this makes it very hard to use composer because the
product doesn't do what I expect it to do. I am really trying to use it for real
work by editing documents I've created in 4.x.

Comment 5

[Syd Logan]

minus per editorbase triage

Comment 6

[Joe Francis]

Lisa, I think the real issue here is to fix any bugs that cause you to have
unintented blank lines in list items.  then ou won't get into this state by
accident.

The situation that first got you here is not fxed on the trunk.  I think it is a
mistake to try and change the behavior of make list in this regard, so marking
wontfix.

Comment 7

[lchiang]

Ok. We can fix bugs causing me to get into this state, but how do I fix it if I
am bringing a document which I've always been able to edit from within 4.x and
try to edit this document in the current builds?   I was not able to find any
way to fix this without having to go back to 4.x to clean up my document after
I've edited it in the current build.

Comment 8

[sujay]

Joe, are you sure there is nothing we can fix here?

Comment 9

[sujay]

Lisa, should we REOPEN? what do you think?

Comment 10

[lchiang]

It's ok if it's not fixed if we have a workaround for the user.  For example,
how do I get out of this bad state if I have deleted 4.7 from my system?

Comment 11

[sujay]

Joe, we'd like to have some kind of workaround for this...

Any ideas?

Comment 12

[Joe Francis]

Lisa, I am not totally sure which issue you are talking about anymore, so I will 
address both:

1) In 4.x, the old editor usually put a single space inside of (otherwise) empty 
list items.  For a while this caused NS6.x Composer some problems, as you have 
seen.  This issue is fixed on the trunk, and I will try to get the fix on the 
branch.  So no workaround is needed, we have a fix.

2) The particular issue rasied in this bug was that if you had a list item with 
some blank lines in it, you could not unlist the item by clicking on the list 
button.  The workaround is to delete the blank lines in the list item first.  
Note that this workaround does not require going to 4x.

Going to 4.x is no longer requirted to work around either of these issues, and 
also going to 4.x will no longer *cause* either of these two issues.

Does that help?

Comment 13

[lchiang]

Joe - I will give these a try on the trunk builds to see if they are fixed. 
Regarding item 2, I'm not sure if the workaround will works since I don't know
if I will see a blank line item.

Comment 14

[sujay]

verified.