[Pontoon] diff view for suggestions

RESOLVED FIXED

Status

Webtools
Pontoon
P2
enhancement
RESOLVED FIXED
4 months ago
3 months ago

People

(Reporter: tomer, Unassigned)

Tracking

Trunk

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

4 months ago
When there is multiple suggestions, or an approved translation and new suggestions, in order to decide which translation should be used, the approver is required to read all translations and decide which is the most suitable translation. A diff view, very similar to what we have in version controls, would make our work easier, as we could easily see what which characters were added or removed. 

I think that such feature should be optional toggle, as some persons may find it distracting. The diff could always be made against the string in the editing field, which contains the approved translation, or against the original string, in case there is no approved string.
I love the idea.

We could make use of jsdiff or something similar:
http://tobyho.com/2013/11/05/jsdiff-for-comparing-text/
Priority: -- → P2

Comment 2

3 months ago
Commit pushed to master at https://github.com/mozilla/pontoon

https://github.com/mozilla/pontoon/commit/0b2ef7cb653e385794b394704263ccbbaf9eb63e
Bug 1329003 diff suggestions (#527)

* Move JS libraries to a lib folder

* Fix bug 1329003: Show suggestions as diffs

Comment 3

3 months ago
Commit pushed to master at https://github.com/mozilla/pontoon

https://github.com/mozilla/pontoon/commit/365808c4f11bfa4c18f42aafdc0ad7e4c2ad615c
Bug 1329003 diff suggestions (#527)

* Move JS libraries to a lib folder

* Fix bug 1329003: Show suggestions as diffs
Matjaz, which library did you end up using?
(In reply to Axel Hecht [:Pike] from comment #4)
> Matjaz, which library did you end up using?

Fast-diff, which is simplified diff-match-patch:
https://www.npmjs.com/package/fast-diff

I just learned the original library has some nice options that increase human readability:
https://neil.fraser.name/software/diff_match_patch/svn/trunk/demos/demo_diff.html

Comment 6

3 months ago
Commits pushed to master at https://github.com/mozilla/pontoon

https://github.com/mozilla/pontoon/commit/7f284b0d12a14c2eea93821b6cc4ec347b38a7d0
Bug 1329003: improve diff experience
* Use diff-match-patch options for better readability
* Hide diff by default and use toggle to turn it on and off

https://github.com/mozilla/pontoon/commit/b95fcdc92eb89341344eb63fa06739a988e1c3ab
Merge pull request #532 from BychekRU/bug-1329003

Bug 1329003: improve diff experience
Status: NEW → RESOLVED
Last Resolved: 3 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.