Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Enable no-lone-blocks rule for eslint

RESOLVED FIXED in Firefox 53

Status

()

Toolkit
General
RESOLVED FIXED
7 months ago
7 months ago

People

(Reporter: jaws, Assigned: jaws)

Tracking

unspecified
mozilla53
Points:
---

Firefox Tracking Flags

(firefox53 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

There are seven unnecessary blocks that were found by this rule. These blocks just create noise within the code and could potentially mislead a developer to think that a variable or function is scoped to the block that it is defined in.
Comment hidden (mozreview-request)

Comment 2

7 months ago
mozreview-review
Comment on attachment 8824226 [details]
Bug 1329013 - Enable no-lone-blocks rule for eslint and remove the seven unnecessary blocks that it found.

https://reviewboard.mozilla.org/r/102738/#review103510
Attachment #8824226 - Flags: review?(dtownsend) → review+

Comment 3

7 months ago
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8f982926c7e5
Enable no-lone-blocks rule for eslint and remove the seven unnecessary blocks that it found. r=mossop

Comment 4

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/8f982926c7e5
Status: ASSIGNED → RESOLVED
Last Resolved: 7 months ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.