Enable the no-useless-return rule for eslint

RESOLVED FIXED in Firefox 53

Status

()

Toolkit
General
RESOLVED FIXED
4 months ago
4 months ago

People

(Reporter: jaws, Assigned: jaws)

Tracking

unspecified
mozilla53
Points:
---

Firefox Tracking Flags

(firefox53 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

There are 47 errors found with this rule enabled. eslint provides a --fix option to autofix these errors. I have manually inspected the fixes to make sure that they are correct.
Comment hidden (mozreview-request)

Comment 2

4 months ago
mozreview-review
Comment on attachment 8824230 [details]
Bug 1329017 - Enable the no-useless-return rule for eslint and use eslint --fix to autofix the errors.

https://reviewboard.mozilla.org/r/102750/#review103452

Yay, another of my favourite rules enabled :-) 

Thanks
Attachment #8824230 - Flags: review?(standard8) → review+
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 5

4 months ago
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/72e93073be64
Enable the no-useless-return rule for eslint and use eslint --fix to autofix the errors. r=standard8

Comment 6

4 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/72e93073be64
Status: ASSIGNED → RESOLVED
Last Resolved: 4 months ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.