1329017 - Enable the no-useless-return rule for eslint

Status: RESOLVED FIXED

(Toolkit :: General, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

There are 47 errors found with this rule enabled. eslint provides a --fix option to autofix these errors. I have manually inspected the fixes to make sure that they are correct.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1329017 - Enable the no-useless-return rule for eslint and use eslint --fix to autofix the errors.

Review commit: https://reviewboard.mozilla.org/r/102750/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/102750/

Comment 2

[Mark Banner (:standard8)]

Comment on attachment 8824230 [details]
Bug 1329017 - Enable the no-useless-return rule for eslint and use eslint --fix to autofix the errors.

https://reviewboard.mozilla.org/r/102750/#review103452

Yay, another of my favourite rules enabled :-) 

Thanks

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8824230 [details]
Bug 1329017 - Enable the no-useless-return rule for eslint and use eslint --fix to autofix the errors.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/102750/diff/1-2/

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8824230 [details]
Bug 1329017 - Enable the no-useless-return rule for eslint and use eslint --fix to autofix the errors.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/102750/diff/2-3/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/72e93073be64
Enable the no-useless-return rule for eslint and use eslint --fix to autofix the errors. r=standard8

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/72e93073be64